mirror of
https://github.com/SabreTools/MPF.git
synced 2026-02-04 05:35:52 +00:00
Out of Memory after DiscImageCreator finishes #304
Reference in New Issue
Block a user
Delete Branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @Feathered-Serpent on GitHub (Jun 11, 2021).
Originally assigned to: @mnadareski on GitHub.
Version
What version are you using?
Build
What runtime version are you using?
Describe the issue
The Witcher Enhanced Edition has two Audio CDs and a DVD delivered as bonus in the case. Upon trying to backup the first Audio CD I get the following error after DiscImageCreator finishes and MPF should ask me for the disc information:
I assume it is because the disc produces a LOT of Subchannel errors. After DiscImageCreator ends, the following files (with sizes) are in the export directory:
As you can see, the file is larger than 1 GB. This happens with two different Plextor drives (W4012TA and PX-W5224TA) as well as with Asus BW-16D1HT. The file size of the file is different on each drive, though only barely. The disc has been cleaned carefully.
The MPF.exe uses up to 3.2 GB of RAM during the step "Extracting output information from output files..."
To Reproduce
One would have to backup the audio CD from The Witcher Enhanced Edition
Expected behavior
MPF shouldn't crash I guess? Is there a 64 Bit version?
Additional context
I know that Audio CDs are usually not submitted anyway, yet this one belongs to the game, same with another Audio CD and even a DVD with content from the producers.
But maybe that error might come at some point else from someone else at a different game at some point. So I think it's worth submitting.
If I make a duplicate file search, the image file itself is always identical aka every single one of the 29 bin files is identical from all three drives and so is the scm and img file.
Only those files stay in the Plextor rips if I remove the duplicate files:
(I could provide those files if necessary)
So it seems, the image itself is fine, I guess? The second Audio CD produces a Audio CD_subError file with 81 KB in size.
@mnadareski commented on GitHub (Jun 19, 2021):
Turns out, that absolutely massive file was the issue when it does the artifact serialization. Note to self: make artifact serialization a separate option to fix this.