SabreTools/MPF
1
0
Fork 0
mirror of https://github.com/SabreTools/MPF.git synced 2026-02-04 05:35:52 +00:00
Code Issues 392 Packages Projects Releases 20 Wiki Activity

[Problem] warning about missing disc when an old Macintosh HFS CD-ROM is inserted #343

New Issue
Closed
opened 2026-01-29 16:14:40 +00:00 by claunia · 4 comments
claunia commented 2026-01-29 16:14:40 +00:00
Owner
Copy Link

Originally created by @gingerbeardman on GitHub (Oct 22, 2021).

Originally assigned to: @mnadareski on GitHub.

Version
What version are you using?

  • Stable release (2.1-7f4921a4)

Build
What runtime version are you using?

  • .NET Framework 4.8 running on (Windows 7 32-bit)

Describe the issue

Apps warns of "missing disc" when an old Macintosh HFS CD-ROM is inserted

To Reproduce
Steps to reproduce the behavior:

  1. insert an old HFS partitioned Macintosh CD-ROM
  2. Scan for disks
  3. Start dumping
  4. See warning

Expected behavior

  • Should not warn that disc is missing when one is present

Screenshots

  • In this screenshot we can see ISO Buster recognising and presenting information about the CD
  • I had to enter the information manually in MPF
  • The warning that the disc is missing (not true)
Screen shot 2021-10-22 at 21 10 28

Additional context

  • Maybe it's possible to read the HFS partition information like ISO Buster can? Let me know if I should file a new REQ for that.
  • Default Media Type ("Apple Macintosh" for me) is also ignored in this situation
Originally created by @gingerbeardman on GitHub (Oct 22, 2021). Originally assigned to: @mnadareski on GitHub. **Version** What version are you using? - [x] Stable release (2.1-7f4921a4) **Build** What runtime version are you using? - [x] .NET Framework 4.8 running on (Windows 7 32-bit) **Describe the issue** Apps warns of "missing disc" when an old Macintosh HFS CD-ROM is inserted **To Reproduce** Steps to reproduce the behavior: 1. insert an old HFS partitioned Macintosh CD-ROM 2. Scan for disks 3. Start dumping 4. See warning **Expected behavior** - Should not warn that disc is missing when one is present **Screenshots** - In this screenshot we can see ISO Buster recognising and presenting information about the CD - I had to enter the information manually in MPF - The warning that the disc is missing (not true) <img width="1022" alt="Screen shot 2021-10-22 at 21 10 28" src="https://user-images.githubusercontent.com/49612/138517300-aaaa6d97-2d44-4126-a82f-1ee9f6dd602a.png"> **Additional context** - Maybe it's possible to read the HFS partition information like ISO Buster can? Let me know if I should file a new REQ for that. - Default Media Type ("Apple Macintosh" for me) is also ignored in this situation
claunia added the wontfixinvalid labels 2026-01-29 16:14:40 +00:00
claunia commented 2026-01-29 16:14:41 +00:00
Author
Owner
Copy Link

@Whovian9369 commented on GitHub (Oct 22, 2021):

That's expected, and if anything is a Windows issue.
From what I'm aware, MPF depends on Windows being able to mount a partition on the disc for the MPF "Is there a disc?" check to be properly completed and thus not show the error.
Windows cannot mount an HFS partition, so it isn't necessarily aware that there's a disc in the drive either.

@Whovian9369 commented on GitHub (Oct 22, 2021): That's expected, and if anything is a Windows issue. From what I'm aware, MPF depends on Windows being able to mount a partition on the disc for the MPF "Is there a disc?" check to be properly completed and thus not show the error. Windows cannot mount an HFS partition, so it isn't necessarily aware that there's a disc in the drive either.
claunia commented 2026-01-29 16:14:41 +00:00
Author
Owner
Copy Link

@gingerbeardman commented on GitHub (Oct 22, 2021):

But ISO Buster recognises it just fine?

@gingerbeardman commented on GitHub (Oct 22, 2021): But ISO Buster recognises it just fine?
claunia commented 2026-01-29 16:14:41 +00:00
Author
Owner
Copy Link

@mnadareski commented on GitHub (Oct 22, 2021):

I'm not even attempting to fix this. I'm relying on Windows to tell me if a disc is in the drive. If you know better, like for 3DO or Mac discs, just hit "Yes". That's specifically why that popup is there.

@mnadareski commented on GitHub (Oct 22, 2021): I'm not even attempting to fix this. I'm relying on Windows to tell me if a disc is in the drive. If you know better, like for 3DO or Mac discs, just hit "Yes". That's specifically why that popup is there.
claunia commented 2026-01-29 16:14:42 +00:00
Author
Owner
Copy Link

@gingerbeardman commented on GitHub (Oct 23, 2021):

OK, thanks.

Any chance of a preference to turn off the warning popup?

I'm also wondering how I would get both the start dumping button to enable, and this warning to display, if there wasn't a disc in the drive? To me the alert seems superfluous, but I'm interested if I'm missing something? @mnadareski

@gingerbeardman commented on GitHub (Oct 23, 2021): OK, thanks. Any chance of a preference to turn off the warning popup? I'm also wondering how I would get both the start dumping button to enable, and this warning to display, if there wasn't a disc in the drive? To me the alert seems superfluous, but I'm interested if I'm missing something? @mnadareski
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
duplicate
enhancement
good first issue
help wanted
invalid
pull-request
Mirrored from GitHub Pull Request
 question
regression
wontfix
No Label invalid wontfix
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: SabreTools/MPF#343
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?