SabreTools/MPF
1
0
Fork 0
mirror of https://github.com/SabreTools/MPF.git synced 2026-02-03 21:29:27 +00:00
Code Issues 392 Packages Projects Releases 20 Wiki Activity

[Problem] If you close submission info window w/ Enter, you lose text in current field. #349

New Issue
Closed
opened 2026-01-29 16:14:50 +00:00 by claunia · 1 comment
claunia commented 2026-01-29 16:14:50 +00:00
Owner
Copy Link

Originally created by @intothisworld on GitHub (Oct 23, 2021).

Originally assigned to: @mnadareski on GitHub.

Before You Submit

  • Remember to try the latest WIP build to see if the issue has already been addressed.
  • Is it copy protection related? If so, report the issue here instead.
  • .NET Core 3.1 and .NET 5.0 have known issues, please try using another build to reproduce the error
  • Check multiple discs to help narrow down the issue
  • Check the Options to see if changing any of those affects your issue.

If all of those fail, then continue...

Version
What version are you using?

  • Stable release (2.1)
  • WIP release (version here)

Build
What runtime version are you using?

  • .NET Framework 4.7.2 running on (Operating System)
  • .NET Framework 4.8 running on (Windows 10, 64-bit)
  • .NET Core 3.1 running on (Operating System)

Describe the issue
I just noticed that some of my !submissionInfo txt files were missing entries that I know I'd punched in. Did some experimentation and realized that if you just press Enter to finalize the submission info window, whatever field you filled in last won't save to the txt file. I suspect that if you tab out of it or click into a new field beforehand, you'd be fine (haven't confirmed), but if you just finish your last entry and immediately press enter, you'll lose whatever text you just punched into that field. So far I've only confirmed this happening with the ringcode fields from audio CDs. I haven't been able to try any other ones, but will do with next disc I dump.

To Reproduce
Steps to reproduce the behavior:

  1. Dump a disc.
  2. Punch some text into a field (ringcodes are what I've seen myself so far)
  3. Hit 'Enter' to close window.
  4. Check !submissionInfo text file.

Expected behavior
The text to save to the Submission Info file.

Screenshots
If applicable, add screenshots to help explain your problem.

Additional context
Add any other context about the problem here.

Originally created by @intothisworld on GitHub (Oct 23, 2021). Originally assigned to: @mnadareski on GitHub. **Before You Submit** - Remember to try the [latest WIP build](https://ci.appveyor.com/project/mnadareski/mpf/build/artifacts) to see if the issue has already been addressed. - Is it copy protection related? If so, report the issue [here](https://github.com/mnadareski/BurnOutSharp/issues) instead. - .NET Core 3.1 and .NET 5.0 have known issues, please try using another build to reproduce the error - Check multiple discs to help narrow down the issue - Check the Options to see if changing any of those affects your issue. If all of those fail, then continue... **Version** What version are you using? - [x] Stable release (2.1) - [ ] WIP release (version here) **Build** What runtime version are you using? - [ ] .NET Framework 4.7.2 running on (Operating System) - [x] .NET Framework 4.8 running on (Windows 10, 64-bit) - [ ] .NET Core 3.1 running on (Operating System) **Describe the issue** I just noticed that some of my !submissionInfo txt files were missing entries that I know I'd punched in. Did some experimentation and realized that if you just press Enter to finalize the submission info window, whatever field you filled in last won't save to the txt file. I suspect that if you tab out of it or click into a new field beforehand, you'd be fine (haven't confirmed), but if you just finish your last entry and immediately press enter, you'll lose whatever text you just punched into that field. So far I've only confirmed this happening with the ringcode fields from audio CDs. I haven't been able to try any other ones, but will do with next disc I dump. **To Reproduce** Steps to reproduce the behavior: 1. Dump a disc. 2. Punch some text into a field (ringcodes are what I've seen myself so far) 3. Hit 'Enter' to close window. 4. Check !submissionInfo text file. **Expected behavior** The text to save to the Submission Info file. **Screenshots** If applicable, add screenshots to help explain your problem. **Additional context** Add any other context about the problem here.
claunia added the help wantedbug labels 2026-01-29 16:14:50 +00:00
claunia commented 2026-01-29 16:14:52 +00:00
Author
Owner
Copy Link

@mnadareski commented on GitHub (Jan 4, 2022):

Possibly addressed by 9e4af1d66b

@mnadareski commented on GitHub (Jan 4, 2022): Possibly addressed by https://github.com/SabreTools/MPF/commit/9e4af1d66bf539d5e10d4b9743c7eacaa13f711c
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
duplicate
enhancement
good first issue
help wanted
invalid
pull-request
Mirrored from GitHub Pull Request
 question
regression
wontfix
No Label bug help wanted
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: SabreTools/MPF#349
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?