SabreTools/MPF
1
0
Fork 0
mirror of https://github.com/SabreTools/MPF.git synced 2026-02-03 21:29:27 +00:00
Code Issues 392 Packages Projects Releases 20 Wiki Activity

[Problem] minor issue: use of both disk and disc spellings #350

New Issue
Closed
opened 2026-01-29 16:14:53 +00:00 by claunia · 4 comments
claunia commented 2026-01-29 16:14:53 +00:00
Owner
Copy Link

Originally created by @gingerbeardman on GitHub (Oct 22, 2021).

Originally assigned to: @mnadareski on GitHub.

Version
What version are you using?

  • Stable release (2.1-7f4921a4)

Build
What runtime version are you using?

  • .NET Framework 4.8 running on (Windows 7 32-bit)

Describe the issue

The app uses two different spellings:

  • disc
  • disk

To Reproduce

  • Scan for disks
  • Missing Disc
  • DiscImageCreator Path
  • Show Disc Info
  • etc

Expected behavior

  • one spelling should be used throughout
  • Disc refers to optical media
  • Disk refers to other types of media
  • should be consistent

Screenshots

Screen shot 2021-10-22 at 21 28 12
Originally created by @gingerbeardman on GitHub (Oct 22, 2021). Originally assigned to: @mnadareski on GitHub. **Version** What version are you using? - [x] Stable release (2.1-7f4921a4) **Build** What runtime version are you using? - [x] .NET Framework 4.8 running on (Windows 7 32-bit) **Describe the issue** The app uses two different spellings: - disc - disk **To Reproduce** - Scan for disks - Missing Disc - DiscImageCreator Path - Show Disc Info - etc **Expected behavior** - one spelling should be used throughout - Disc refers to optical media - Disk refers to other types of media - should be consistent **Screenshots** <img width="176" alt="Screen shot 2021-10-22 at 21 28 12" src="https://user-images.githubusercontent.com/49612/138518924-53821453-8e2b-4ea0-a3e2-9808f79191d9.png">
claunia added the enhancementhelp wanted labels 2026-01-29 16:14:53 +00:00
claunia commented 2026-01-29 16:14:55 +00:00
Author
Owner
Copy Link

@PurpleNekoNova commented on GitHub (Oct 22, 2021):

MPF doesn't do just optical media, it also does hard drives, flash media, floppies, etc.

@PurpleNekoNova commented on GitHub (Oct 22, 2021): MPF doesn't do just optical media, it also does hard drives, flash media, floppies, etc.
claunia commented 2026-01-29 16:14:56 +00:00
Author
Owner
Copy Link

@gingerbeardman commented on GitHub (Oct 22, 2021):

Right, my point is that it should strive to be consistent.

@gingerbeardman commented on GitHub (Oct 22, 2021): Right, my point is that it should strive to be consistent.
claunia commented 2026-01-29 16:14:56 +00:00
Author
Owner
Copy Link

@mnadareski commented on GitHub (Oct 22, 2021):

I'd appreciate someone to comb through and put the right words in the right places. As it stands, I think it's understandable enough for most users. I'll leave this open if I have time.

@mnadareski commented on GitHub (Oct 22, 2021): I'd appreciate someone to comb through and put the right words in the right places. As it stands, I think it's understandable enough for most users. I'll leave this open if I have time.
claunia commented 2026-01-29 16:14:57 +00:00
Author
Owner
Copy Link

@gingerbeardman commented on GitHub (Oct 23, 2021):

Thanks @sadikyo !

@gingerbeardman commented on GitHub (Oct 23, 2021): Thanks @sadikyo !
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
duplicate
enhancement
good first issue
help wanted
invalid
pull-request
Mirrored from GitHub Pull Request
 question
regression
wontfix
No Label enhancement help wanted
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: SabreTools/MPF#350
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?