MPF no longer handles '.' in Output Filename correctly #374

New Issue

claunia · 2026-01-29T16:15:26Z

claunia commented

2026-01-29 16:15:26 +00:00

Originally created by @cdifan on GitHub (Jan 1, 2022).

Originally assigned to: @mnadareski on GitHub.

Version
What version are you using?

Stable release 2.2
WIP release (version here)

Build
What runtime version are you using?

.NET Framework 4.7.2 running on (Operating System)
.NET Framework 4.8 running on Windows 10
.NET Core 3.1 running on (Operating System)

Describe the issue
When you type or paste a period '.' in the Output Filename field, MPF 2.2 no longer replaces it with an underscore '_', e.g. it does not change "XXX 1.0" to "XXX 1_0" (MPF 2.1 used to do this). As a result, after running DIC, MPF will complain about not finding output files because it will replace anything after the first period with the expected suffix, e.g. it will look for "XXX 1.cue" and "XXX 1_disc.txt" instead of the correct "XXX 1.0.cue" and "XXX 1.0_disc.txt" which are generated by DIC.

To Reproduce
Steps to reproduce the behavior:

Start MPG
Type e.g. "XXX 1.0" in the Output Filename field.
Insert a dumpable disc.
Click on 'Start Dumping'
Wait until DIC finishes
See red errors about missing DIC output files in Log Output field

Expected behavior
Either restore the previous behaviour (replace '.' with '_') in the filename) or (preferred solution) correct the DIC output file search to find the correct files.

Additional context
Everything works fine if you use e.g. "XXX 1_0" in the Output Filename. Also, there are no issues with period characters in the Output Directory field.

Originally created by @cdifan on GitHub (Jan 1, 2022). Originally assigned to: @mnadareski on GitHub. **Version** What version are you using? - [X] Stable release 2.2 - [ ] WIP release (version here) **Build** What runtime version are you using? - [ ] .NET Framework 4.7.2 running on (Operating System) - [X] .NET Framework 4.8 running on Windows 10 - [ ] .NET Core 3.1 running on (Operating System) **Describe the issue** When you type or paste a period '.' in the Output Filename field, MPF 2.2 no longer replaces it with an underscore '_', e.g. it does not change "XXX 1.0" to "XXX 1_0" (MPF 2.1 used to do this). As a result, after running DIC, MPF will complain about not finding output files because it will replace anything after the first period with the expected suffix, e.g. it will look for "XXX 1.cue" and "XXX 1_disc.txt" instead of the correct "XXX 1.0.cue" and "XXX 1.0_disc.txt" which are generated by DIC. **To Reproduce** Steps to reproduce the behavior: 1. Start MPG 2. Type e.g. "XXX 1.0" in the Output Filename field. 3. Insert a dumpable disc. 3. Click on 'Start Dumping' 4. Wait until DIC finishes 4. See red errors about missing DIC output files in Log Output field **Expected behavior** Either restore the previous behaviour (replace '.' with '_') in the filename) or (preferred solution) correct the DIC output file search to find the correct files. **Additional context** Everything works fine if you use e.g. "XXX 1_0" in the Output Filename. Also, there are no issues with period characters in the Output Directory field.

claunia added the bug label 2026-01-29 16:15:26 +00:00

claunia closed this issue

2026-01-29 16:15:26 +00:00

claunia commented

2026-01-29 16:15:27 +00:00

@mnadareski commented on GitHub (Jan 1, 2022):

I'd like screenshots of both the UI before dumping when this comes up as well as a copy of what the log says after. I have an idea of what could be causing this issue, but I need to see the input before I'm sure.

@mnadareski commented on GitHub (Jan 1, 2022): I'd like screenshots of both the UI before dumping when this comes up as well as a copy of what the log says after. I have an idea of what could be causing this issue, but I need to see the input before I'm sure.

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: SabreTools/MPF#374