mirror of
https://github.com/SabreTools/MPF.git
synced 2026-02-04 05:35:52 +00:00
[Problem] Generated Metadata sometimes has the (VERIFY THIS) tag which shouldn't apply in those cases. #388
Reference in New Issue
Block a user
Delete Branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @sadikyo on GitHub (Feb 2, 2022).
Originally assigned to: @mnadareski on GitHub.
Version
What version are you using?
Build
What runtime version are you using?
Describe the issue
There is a new feature that places (VERIFY THIS) in front of elements that are pulled from redump so that dumpers verify / correct it. However, this tag is showing up on some items that are generated from the disc/dump, such as Sega Saturn discs. In this example, the version number is internal and should always be generated.
I'm not sure if the version number that MPF is pulling is coming from redump, or generated, but I think it should be generated for these discs, and if so, shouldn't have the VERIFY THIS tag.
To Reproduce
Steps to reproduce the behavior:
Dump a saturn disc
Look at the version field in the submission window.
It should say (VERIFY THIS) next to the version number
Expected behavior
I would not expect this tag for any generated/extracted item
Screenshots
Additional context