mirror of
https://github.com/SabreTools/MPF.git
synced 2026-02-04 05:35:52 +00:00
[Bug] dr_ring_0_mo1 and dr_ring_0_mo2 typos? #414
Reference in New Issue
Block a user
Delete Branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @JohnVeness on GitHub (Mar 25, 2022).
Originally assigned to: @mnadareski on GitHub.
In the submissionInfo.json file, are
dr_ring_0_mo1anddr_ring_0_mo2typos? All the other fieldnames startd_.@mnadareski commented on GitHub (Mar 25, 2022):
The best way to check is to look a the names of the fields in the Redump new disc form. If they don't match, then they're wrong either because the field names changed or I fat-fingered it.
@JohnVeness commented on GitHub (Mar 25, 2022):
Thanks. I checked a New Disc form, but unfortunately they just have a large text box for the ring codes, not separate ones for individual components. In other words, the New Disc form has neither
dr_ring_0_mo1nord_ring_0_mo1.@mnadareski commented on GitHub (Mar 25, 2022):
I keep forgetting that the public new disc form is different than the internal one. Long story short: you are correct, it was me fat-fingering and then copy-pasting the names. It'll be fixed in a minute.
@JohnVeness commented on GitHub (Mar 25, 2022):
Lovely, thank you. I am very intrigued about the alternative new disc form, though!
@mnadareski commented on GitHub (Mar 25, 2022):
It's nothing secretive, just the staff gets a different New Disc form that is a bit more comprehensive.
@JohnVeness commented on GitHub (Mar 25, 2022):
Ah OK, thanks. At the moment I'm using nightson's user script to parse the JSON into stuff suitable for the public newdisc form. It would be great if there was a publicly accessible interface to just inject the JSON directly, without all the fiddling!
@mnadareski commented on GitHub (Mar 25, 2022):
Oh, we certainly wish there was either an API or any sort of consistency to it, but unfortunately, getting those changes to the Redump site are difficult at best.
@JohnVeness commented on GitHub (Mar 25, 2022):
I understand. Thanks for your openness, and for your tolerance for this off-topic chat!
@mnadareski commented on GitHub (Mar 25, 2022):
No worries, not all of this is obvious, especially when there's so many layers of abstraction going on between dumping your disc and having the metadata appear on the site.