SabreTools/MPF
1
0
Fork 0
mirror of https://github.com/SabreTools/MPF.git synced 2026-02-03 21:29:27 +00:00
Code Issues 392 Packages Projects Releases 20 Wiki Activity

[Problem] !submissionInfo.json can have mixture of "\n" and "\r\n" in Comments #420

New Issue
Closed
opened 2026-01-29 16:16:11 +00:00 by claunia · 0 comments
claunia commented 2026-01-29 16:16:11 +00:00
Owner
Copy Link

Originally created by @JohnVeness on GitHub (Apr 1, 2022).

Originally assigned to: @mnadareski on GitHub.

Version
What version are you using?

  • Stable release (2.3)

Build
What runtime version are you using?

  • .NET Framework 4.8 running on Windows 10

Describe the issue
The !submissionInfo.json file can end up with both "\n" and "\r\n" encoded line endings in the Comments field.

To Reproduce
Steps to reproduce the behavior:

  1. Dump a DVD-ROM
  2. In the submission info window, fill in a multi-line (that is, using the return key) entry in the Comments field
  3. Observe the resultant !submissionInfo.json contains both "\n" and "\r\n" encoded line endings in "d_comments".

Expected behavior
Only "\n" in the !submissionInfo.json file.

Screenshots
"d_comments": "[T:VOL] ANNO1701\nInlay serial: ECD900032D\r\nManual serial: ECD900032D",

Originally created by @JohnVeness on GitHub (Apr 1, 2022). Originally assigned to: @mnadareski on GitHub. **Version** What version are you using? - [x] Stable release (2.3) **Build** What runtime version are you using? - [x] .NET Framework 4.8 running on Windows 10 **Describe the issue** The !submissionInfo.json file can end up with both "\n" and "\r\n" encoded line endings in the Comments field. **To Reproduce** Steps to reproduce the behavior: 1. Dump a DVD-ROM 2. In the submission info window, fill in a multi-line (that is, using the return key) entry in the Comments field 3. Observe the resultant !submissionInfo.json contains both "\n" and "\r\n" encoded line endings in "d_comments". **Expected behavior** Only "\n" in the !submissionInfo.json file. **Screenshots** `"d_comments": "[T:VOL] ANNO1701\nInlay serial: ECD900032D\r\nManual serial: ECD900032D",`
claunia added the bug label 2026-01-29 16:16:11 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
duplicate
enhancement
good first issue
help wanted
invalid
pull-request
Mirrored from GitHub Pull Request
 question
regression
wontfix
No Label bug
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: SabreTools/MPF#420
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?