[Request] Include "CD-R" in comments when disc is a CD-R #439

Closed
opened 2026-01-29 16:16:28 +00:00 by claunia · 5 comments
Owner

Originally created by @PurpleNekoNova on GitHub (Aug 1, 2022).

Originally assigned to: @mnadareski on GitHub.

Suggestion:
Include "CD-R" in the submissioninfo.txt comments field when the disc is detected as a CD-R in the *_disc.txt file.
It's included under:

image

Perhaps do the same for DVD-Rs but I do not have a reference for this.

Originally created by @PurpleNekoNova on GitHub (Aug 1, 2022). Originally assigned to: @mnadareski on GitHub. Suggestion: Include "CD-R" in the submissioninfo.txt comments field when the disc is detected as a CD-R in the *_disc.txt file. It's included under: ![image](https://user-images.githubusercontent.com/68273043/182207566-a73535aa-24d5-48dd-a51b-11c83ebb2a05.png) Perhaps do the same for DVD-Rs but I do not have a reference for this.
claunia added the enhancement label 2026-01-29 16:16:28 +00:00
Author
Owner

@sadikyo commented on GitHub (Aug 1, 2022):

Yes please - this would be very helpful!

@sadikyo commented on GitHub (Aug 1, 2022): Yes please - this would be very helpful!
Author
Owner

@intothisworld commented on GitHub (Oct 5, 2022):

+1. Great idea

@intothisworld commented on GitHub (Oct 5, 2022): +1. Great idea
Author
Owner

@mnadareski commented on GitHub (Oct 19, 2022):

Should be done as of 0903855d5c and 709d980b67

@mnadareski commented on GitHub (Oct 19, 2022): Should be done as of https://github.com/SabreTools/MPF/commit/0903855d5cd61c0fe1eacee6f0dc69d247c9cff4 and https://github.com/SabreTools/MPF/commit/709d980b678750940d0ce9898a445438aab3429f
Author
Owner

@mnadareski commented on GitHub (Oct 20, 2022):

Multiple instances of the DiscType in DIC logs should be fixed as of c391dbd3c8

@mnadareski commented on GitHub (Oct 20, 2022): Multiple instances of the DiscType in DIC logs should be fixed as of https://github.com/SabreTools/MPF/commit/c391dbd3c88035609d00f24bd296896aee3e724c
Author
Owner

@mnadareski commented on GitHub (Oct 20, 2022):

Confirmed working with the above for normal DVD and CD as well as DVD-R and CD-R. All of the cases that we were concerned about with this.

@mnadareski commented on GitHub (Oct 20, 2022): Confirmed working with the above for normal DVD and CD as well as DVD-R and CD-R. All of the cases that we were concerned about with this.
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: SabreTools/MPF#439