[Request] Internal Reorganization of Comment Fields #465

New Issue

Closed

opened 2026-01-29 16:16:54 +00:00 by claunia · 1 comment

claunia commented 2026-01-29 16:16:54 +00:00

Owner

Copy Link

Originally created by @mnadareski on GitHub (Oct 19, 2022).

Originally assigned to: @mnadareski on GitHub.

Instead of relying entirely on the actual model that Redump uses for dealing with comment fields (that is, sticking them all into comments possibly with a site tag attached), make things like publisher IDs and other information that goes there into separate internal fields that then get shoved into Comments. This is a logical extension of the "Special Fields" dictionaries that exist right now.

Originally created by @mnadareski on GitHub (Oct 19, 2022). Originally assigned to: @mnadareski on GitHub. Instead of relying entirely on the actual model that Redump uses for dealing with comment fields (that is, sticking them all into comments possibly with a site tag attached), make things like publisher IDs and other information that goes there into separate internal fields that then get shoved into Comments. This is a logical extension of the "Special Fields" dictionaries that exist right now.

claunia added the enhancement label 2026-01-29 16:16:54 +00:00

claunia closed this issue 2026-01-29 16:16:54 +00:00

claunia commented 2026-01-29 16:16:55 +00:00

Author

Owner

Copy Link

@mnadareski commented on GitHub (Oct 11, 2023):

This isn't going to be a thing until there's an actual reason to separate out the values. I'm closing this for now.

@mnadareski commented on GitHub (Oct 11, 2023): This isn't going to be a thing until there's an actual reason to separate out the values. I'm closing this for now.

claunia referenced this issue 2026-01-29 16:24:55 +00:00

[PR #465] [MERGED] Detect EOF during the search for error counts #1025

claunia referenced this issue 2026-01-29 16:24:56 +00:00

[PR #465] Detect EOF during the search for error counts #1028

Sign in to join this conversation.

No Branch/Tag Specified

Branches Tags

master

rolling

3.6.0

3.5.0

3.4.2

3.4.1

3.4.0

3.3.3

3.3.2

3.3.1

3.3.0

3.2.4

3.2.3

3.2.2

3.2.1

3.2.0

3.1.9

3.1.8

3.1.7

3.1.6

3.1.5

3.1.4

3.1.3

3.1.2

check-rolling

ui-rolling

3.1.1

3.1.0

3.0.3

3.0.2

3.0.1

3.0.0

2.7.5

2.7.4

2.7.3

2.7.2

2.7.1

2.7.0

2.6.6

2.6.5

2.6.4

2.6.3

2.6.2

2.6.1

2.6

2.5

2.4

2.3

2.2

2.1

2.0

1.18

1.17.1

1.17

1.16.1

1.16

1.15

1.14

1.13

1.12.2

1.12.1

1.12

1.11

1.10

1.07

1.06

1.05.1

1.05

1.04b

1.04a

1.04

1.03

1.02b

1.02

1.01d

1.01c

1.01b

Labels

Clear labels

bug

duplicate

enhancement

good first issue

help wanted

invalid

pull-request

Mirrored from GitHub Pull Request

question

regression

wontfix

No Label enhancement

Milestone

No items

No Milestone

Projects

Clear projects

No project

Assignees

Clear assignees

claunia

No Assignees

1 Participants

Notifications

Subscribe

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: SabreTools/MPF#465