[Problem] Relative output path is improperly sanitized #492

New Issue

Closed

opened 2026-01-29 16:17:21 +00:00 by claunia · 1 comment

claunia commented 2026-01-29 16:17:21 +00:00

Owner

Copy Link

Originally created by @CookiePLMonster on GitHub (Feb 21, 2023).

Originally assigned to: @mnadareski on GitHub.

Version
What version are you using?

• Stable release - 2.4
• WIP release 49800cf0ed
  (issue happens on both)

Build
What runtime version are you using?

• .NET Framework 4.8 running on Windows 10

Describe the issue
Specifying a relative output path that traverses upwards should technically be supported, but it misbehaves. Instead of .. advancing the directory up, it gets sanitized to __ and creates a subdirectory.

To Reproduce
Steps to reproduce the behavior - these steps assume MPF resides in F:\MPF:

1. Open MPF.
2. Set an Output directory to ..\dumps.
3. Start dumping any disc - in my case it's via DIC, but I suspect any media may be affected.
4. Observe that the dump and logs are being created inside F:\MPF\__\dumps.

Expected behavior
Dumps should be created in F:\dumps.

Originally created by @CookiePLMonster on GitHub (Feb 21, 2023). Originally assigned to: @mnadareski on GitHub. **Version** What version are you using? - [x] Stable release - 2.4 - [x] WIP release https://github.com/SabreTools/MPF/commit/49800cf0edddfe76942f4164a6df95a131ed6e73 (issue happens on both) **Build** What runtime version are you using? - [x] .NET Framework 4.8 running on **Windows 10** **Describe the issue** Specifying a relative output path that traverses upwards should technically be supported, but it misbehaves. Instead of `..` advancing the directory up, it gets sanitized to `__` and creates a subdirectory. **To Reproduce** Steps to reproduce the behavior - **these steps assume MPF resides in `F:\MPF`**: 1. Open MPF. 2. Set an Output directory to `..\dumps`. 3. Start dumping any disc - in my case it's via DIC, but I suspect any media may be affected. 4. Observe that the dump and logs are being created inside `F:\MPF\__\dumps`. **Expected behavior** Dumps should be created in `F:\dumps`.

claunia added the bug label 2026-01-29 16:17:21 +00:00

claunia closed this issue 2026-01-29 16:17:21 +00:00

claunia commented 2026-01-29 16:17:22 +00:00

Author

Owner

Copy Link

@CookiePLMonster commented on GitHub (Mar 11, 2023):

Either not fixed or regressed back to how it was, tested on fa04461631.

@CookiePLMonster commented on GitHub (Mar 11, 2023): Either not fixed or regressed back to how it was, tested on fa04461631277fda72d849fb8e4944ede308f4f9. 

Sign in to join this conversation.

No Branch/Tag Specified

Branches Tags

master

rolling

3.6.0

3.5.0

3.4.2

3.4.1

3.4.0

3.3.3

3.3.2

3.3.1

3.3.0

3.2.4

3.2.3

3.2.2

3.2.1

3.2.0

3.1.9

3.1.8

3.1.7

3.1.6

3.1.5

3.1.4

3.1.3

3.1.2

check-rolling

ui-rolling

3.1.1

3.1.0

3.0.3

3.0.2

3.0.1

3.0.0

2.7.5

2.7.4

2.7.3

2.7.2

2.7.1

2.7.0

2.6.6

2.6.5

2.6.4

2.6.3

2.6.2

2.6.1

2.6

2.5

2.4

2.3

2.2

2.1

2.0

1.18

1.17.1

1.17

1.16.1

1.16

1.15

1.14

1.13

1.12.2

1.12.1

1.12

1.11

1.10

1.07

1.06

1.05.1

1.05

1.04b

1.04a

1.04

1.03

1.02b

1.02

1.01d

1.01c

1.01b

Labels

Clear labels

bug

duplicate

enhancement

good first issue

help wanted

invalid

pull-request

Mirrored from GitHub Pull Request

question

regression

wontfix

No Label bug

Milestone

No items

No Milestone

Projects

Clear projects

No project

Assignees

Clear assignees

claunia

No Assignees

1 Participants

Notifications

Subscribe

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: SabreTools/MPF#492