mirror of
https://github.com/SabreTools/MPF.git
synced 2026-02-08 21:31:47 +00:00
[Request] Suggestion re. pre-filled data #507
Reference in New Issue
Block a user
Delete Branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @mariomadproductions on GitHub (Mar 5, 2023).
When MPF generates its submission info file for a verification, and the user has the program logged into redump, some fields are purposely not pre-filled, or the values have a "(VERIFY THIS) " suffix, to make sure that dumpers check the properties of their dump, and don't inadvertently submit the retrieved data as if it was their own.
However this isn't the case for the following fields that the dumper also needs to check:
I think this should probably be fixed.
@mnadareski commented on GitHub (Mar 13, 2023):
I am going to tend toward pulling more data than less data from Redump for filling in. The only reason it does not pull more is because of unobservant users declining to look at the information that they have decided to submit, just because the UI was trying to be helpful.
There are a few fields that automatically get something like "Verify This", generally things that are likely to change. There are other fields, such as language and region, that are prohibitively difficult to do because they rely on static lists of values that it pulls from.
As a rule, dumpers should be responsible for verifying all information they submit in general. This also doesn't affect users who decline to put in their Redump credentials to pull the information in the first place. That is an optional step that requires user input and comes with an additional burden of responsibility when submitting.
I fundamentally disagree that adding "Verify This" in more places will actually assist the people who ignore these things anyway, but I may make it blindingly obvious in the settings that, if you provide your credentials, you are responsible for validating all information pulled from Redump.
@mariomadproductions commented on GitHub (Mar 14, 2023):
Yeah that makes sense. I think just some kind of clear indication that everything pulled needs to be checked against the actual disc/box. I was thinking something at the top of the txt file itself, but something in the GUI may be better, yeah.
@CookiePLMonster commented on GitHub (Mar 14, 2023):
How about combining this with blocking an ability to submit in the first place if any fields are marked with
VERIFY THIS?@mariomadproductions commented on GitHub (Mar 14, 2023):
You mean that Verify This can't be prepended to these for some reason? How come? But in that case, it could just be appended to the field name (e.g.
Region (VERIFY THIS):@mnadareski commented on GitHub (Mar 14, 2023):
What is spit out by MPF has to be manually input into Redump. There is no automatic process, therefore, cannot be blocked. There are many users who choose to update the submission info after and don't use the UI to fill it in, so saying that an untouched field is a reason to cancel is also not in the cards.
In the end, the UI can only prevent so much. There is nothing stopping a user from removing Verify This, copying from the site, or anything else. The eventual contract is between the dumper and the mods. This is why I'm opposed to just "add more warnings in the info". It just serves to make it harder for those who do it the right way and another thing to ignore for those who don't.
I'm not doing that. That isn't even something that can be accounted for in the UI for users who do things properly. That forces all users to change the text file after, whether they filled in the information themselves or not. See the above explanation for more details.
@mnadareski commented on GitHub (Mar 14, 2023):
The warning on the login tab was added as of
51f955a14c@mnadareski commented on GitHub (Mar 14, 2023):
Currently, the following items have
(VERIFY THIS)prepended (all of which I feel are unnecessary now):@mariomadproductions commented on GitHub (Mar 14, 2023):
That makes sense. And that warning looks good, thanks.
@mnadareski commented on GitHub (Mar 14, 2023):
Currently, the following items are pulled from Redump, if possible:
@mnadareski commented on GitHub (Mar 14, 2023):
For the time being, with the warning being added at login, I will consider this request fulfilled. If there is any need for increased warning in the future, we can have another discussion.