SabreTools/MPF
1
0
Fork 0
mirror of https://github.com/SabreTools/MPF.git synced 2026-02-03 21:29:27 +00:00
Code Issues 392 Packages Projects Releases 20 Wiki Activity

[Request] Don't indent ringcodes in !submissioninfo.txt #517

New Issue
Closed
opened 2026-01-29 16:17:47 +00:00 by claunia · 5 comments
claunia commented 2026-01-29 16:17:47 +00:00
Owner
Copy Link

Originally created by @mariomadproductions on GitHub (Mar 29, 2023).

Originally assigned to: @mnadareski on GitHub.

Don't indent the ringcode section (like how the comment section isn't indented), so its easier to copy and paste. Currently you have to un-indent it, or it looks messed up when pasted into the redump new disc form

Originally created by @mariomadproductions on GitHub (Mar 29, 2023). Originally assigned to: @mnadareski on GitHub. Don't indent the ringcode section (like how the comment section isn't indented), so its easier to copy and paste. Currently you have to un-indent it, or it looks messed up when pasted into the redump new disc form
claunia added the enhancement label 2026-01-29 16:17:47 +00:00
claunia commented 2026-01-29 16:17:48 +00:00
Author
Owner
Copy Link

@mnadareski commented on GitHub (Apr 24, 2023):

It's been a while since I've seen the user-accessible submission form. Do you mind giving a quick screenshot to what that section looks like? I assume that seeing that will explain better why the indentation is an issue.

@mnadareski commented on GitHub (Apr 24, 2023): It's been a while since I've seen the user-accessible submission form. Do you mind giving a quick screenshot to what that section looks like? I assume that seeing that will explain better why the indentation is an issue.
claunia commented 2026-01-29 16:17:49 +00:00
Author
Owner
Copy Link

@sadikyo commented on GitHub (Apr 24, 2023):

I can make a picture for you, but it's basically just a large multi-line box, just like comments, for users.

So it will look a little nicer and also be easier for mods as well, without the indentations.

@sadikyo commented on GitHub (Apr 24, 2023): I can make a picture for you, but it's basically just a large multi-line box, just like comments, for users. So it will look a little nicer and also be easier for mods as well, without the indentations.
claunia commented 2026-01-29 16:17:50 +00:00
Author
Owner
Copy Link

@mnadareski commented on GitHub (Apr 24, 2023):

For anyone who this affects, please try out 6dbbb91438 and see if that looks the way you would expect the de-indented ringcode information to look.

@mnadareski commented on GitHub (Apr 24, 2023): For anyone who this affects, please try out https://github.com/SabreTools/MPF/commit/6dbbb9143864eb2d54b556d4725288ca679d300c and see if that looks the way you would expect the de-indented ringcode information to look.
claunia commented 2026-01-29 16:17:50 +00:00
Author
Owner
Copy Link

@fuzz6001 commented on GitHub (Apr 25, 2023):

It seems to be working.

Common Disc Info:
	Title: (REQUIRED)
	Foreign Title (Non-latin): (OPTIONAL)
	Disc Number / Letter: (OPTIONAL)
	Disc Title: (OPTIONAL)
	System: Audio CD
	Media Type: CD-ROM
	Category: Audio
	Region: SPACE! (CHANGE THIS)
	Languages: SILENCE! (CHANGE THIS)
	Disc Serial: (REQUIRED, IF EXISTS)

	Ringcode Information:

Data Side Mastering Code (laser branded/etched): (REQUIRED, IF EXISTS)
Data Side Mastering SID Code: (REQUIRED, IF EXISTS)
Data Side Toolstamp or Mastering Code (engraved/stamped): (REQUIRED, IF EXISTS)
Data Side Mould SID Code: (REQUIRED, IF EXISTS)
Data Side Additional Mould: (REQUIRED, IF EXISTS)
Label Side Mould SID Code: (REQUIRED, IF EXISTS)

	Barcode: (OPTIONAL)
	Error Count: 0
	Comments:

<b>Universal Hash (SHA-1)</b>: 3f2fd1dbf366bf70b717615092e902de60653df2
<b>Ring non-zero data start</b>: +44090
(OPTIONAL)

	Contents: (OPTIONAL)

Version and Editions:
	Version: (REQUIRED, IF EXISTS)
	Edition/Release: (VERIFY THIS) Original

Extras:
	Primary Volume Descriptor (PVD): Disc has no PVD

Tracks and Write Offsets:
	DAT:

<rom name="dump (Track 1).bin" size="19822656" crc="73aab23f" md5="925bce86729306cd3372096b6ed08461" sha1="27a0f4aae76cac32b9207281b5d7bcffc28ac437" />
<rom name="dump (Track 2).bin" size="21219744" crc="d1cd8ada" md5="82c245196cb6d2afd24a6549b3c6a03b" sha1="d8d73093f2eca03e81b58caea9fbd605261a67c5" />
<rom name="dump (Track 3).bin" size="38438736" crc="bf932393" md5="601d8b667f4efda7cd7fa94fde87a4c2" sha1="027fbfcf08faeb710ef80ea96247f96070bca818" />

	Cuesheet:

FILE "dump (Track 1).bin" BINARY
  TRACK 01 AUDIO
    ISRC JPA600800308
    INDEX 01 00:00:00
FILE "dump (Track 2).bin" BINARY
  TRACK 02 AUDIO
    ISRC JPA600800309
    INDEX 00 00:00:00
    INDEX 01 00:02:40
FILE "dump (Track 3).bin" BINARY
  TRACK 03 AUDIO
    ISRC JPA600800310
    INDEX 00 00:00:00
    INDEX 01 00:02:40

	Write Offset: 0

Dumping Info:
	Dumping Program: redumper v2023.04.10 build_118
	Manufacturer: PLEXTOR
	Model: DVDR PX-760A
	Firmware: 1.07 (08/18/07 15:10)
@fuzz6001 commented on GitHub (Apr 25, 2023): It seems to be working. ``` Common Disc Info: Title: (REQUIRED) Foreign Title (Non-latin): (OPTIONAL) Disc Number / Letter: (OPTIONAL) Disc Title: (OPTIONAL) System: Audio CD Media Type: CD-ROM Category: Audio Region: SPACE! (CHANGE THIS) Languages: SILENCE! (CHANGE THIS) Disc Serial: (REQUIRED, IF EXISTS) Ringcode Information: Data Side Mastering Code (laser branded/etched): (REQUIRED, IF EXISTS) Data Side Mastering SID Code: (REQUIRED, IF EXISTS) Data Side Toolstamp or Mastering Code (engraved/stamped): (REQUIRED, IF EXISTS) Data Side Mould SID Code: (REQUIRED, IF EXISTS) Data Side Additional Mould: (REQUIRED, IF EXISTS) Label Side Mould SID Code: (REQUIRED, IF EXISTS) Barcode: (OPTIONAL) Error Count: 0 Comments: <b>Universal Hash (SHA-1)</b>: 3f2fd1dbf366bf70b717615092e902de60653df2 <b>Ring non-zero data start</b>: +44090 (OPTIONAL) Contents: (OPTIONAL) Version and Editions: Version: (REQUIRED, IF EXISTS) Edition/Release: (VERIFY THIS) Original Extras: Primary Volume Descriptor (PVD): Disc has no PVD Tracks and Write Offsets: DAT: <rom name="dump (Track 1).bin" size="19822656" crc="73aab23f" md5="925bce86729306cd3372096b6ed08461" sha1="27a0f4aae76cac32b9207281b5d7bcffc28ac437" /> <rom name="dump (Track 2).bin" size="21219744" crc="d1cd8ada" md5="82c245196cb6d2afd24a6549b3c6a03b" sha1="d8d73093f2eca03e81b58caea9fbd605261a67c5" /> <rom name="dump (Track 3).bin" size="38438736" crc="bf932393" md5="601d8b667f4efda7cd7fa94fde87a4c2" sha1="027fbfcf08faeb710ef80ea96247f96070bca818" /> Cuesheet: FILE "dump (Track 1).bin" BINARY TRACK 01 AUDIO ISRC JPA600800308 INDEX 01 00:00:00 FILE "dump (Track 2).bin" BINARY TRACK 02 AUDIO ISRC JPA600800309 INDEX 00 00:00:00 INDEX 01 00:02:40 FILE "dump (Track 3).bin" BINARY TRACK 03 AUDIO ISRC JPA600800310 INDEX 00 00:00:00 INDEX 01 00:02:40 Write Offset: 0 Dumping Info: Dumping Program: redumper v2023.04.10 build_118 Manufacturer: PLEXTOR Model: DVDR PX-760A Firmware: 1.07 (08/18/07 15:10) ```
claunia commented 2026-01-29 16:17:51 +00:00
Author
Owner
Copy Link

@mariomadproductions commented on GitHub (Apr 25, 2023):

Looks good to me.

@mariomadproductions commented on GitHub (Apr 25, 2023): Looks good to me.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
duplicate
enhancement
good first issue
help wanted
invalid
pull-request
Mirrored from GitHub Pull Request
 question
regression
wontfix
No Label enhancement
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: SabreTools/MPF#517
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?