SabreTools/MPF
1
0
Fork 0
mirror of https://github.com/SabreTools/MPF.git synced 2026-02-04 05:35:52 +00:00
Code Issues 392 Packages Projects Releases 20 Wiki Activity

[Problem] PS5 Media Type wrongly detected #526

New Issue
Closed
opened 2026-01-29 16:17:59 +00:00 by claunia · 5 comments
claunia commented 2026-01-29 16:17:59 +00:00
Owner
Copy Link

Originally created by @Ragowit on GitHub (Apr 26, 2023).

Originally assigned to: @mnadareski on GitHub.

Version

  • WIP release 2.5-1108

Build

  • .NET Framework 4.8 running on Win 11 22H2
  • .NET 6.0 running on Win 11 22H2

I tried both versions for this issue.

Describe the issue
MPF says Media Type of PS5 disc is BD-ROM-25, when it really is BD-ROM-66. Besides outputting wrong info in the submission info, it also messes up the ringcode information field since MPF believes it's only one layer and not two.

To Reproduce
Dump "Hades (Europe)" or "Back 4 Blood (Europe)" PS5 discs.

Logs can be seen here:
https://github.com/Ragowit/redump-submissions/tree/main/PS5/H/Hades%20(Europe)/20230425_185758
https://github.com/Ragowit/redump-submissions/tree/main/PS5/B/Back%204%20Blood%20(Europe)/20230426_074014

Expected behavior
I expect it to tell it's a BD-ROM-66, with two layers of ringcode information.

Additional context
To my knowledge, the only two valid Media Types for PS5 is BD-ROM-66 (two layers) and BD-ROM-100 (three layers).

Originally created by @Ragowit on GitHub (Apr 26, 2023). Originally assigned to: @mnadareski on GitHub. **Version** - [x] WIP release 2.5-1108 **Build** - [x] .NET Framework 4.8 running on Win 11 22H2 - [x] .NET 6.0 running on Win 11 22H2 I tried both versions for this issue. **Describe the issue** MPF says Media Type of PS5 disc is BD-ROM-25, when it really is BD-ROM-66. Besides outputting wrong info in the submission info, it also messes up the ringcode information field since MPF believes it's only one layer and not two. **To Reproduce** Dump "Hades (Europe)" or "Back 4 Blood (Europe)" PS5 discs. Logs can be seen here: https://github.com/Ragowit/redump-submissions/tree/main/PS5/H/Hades%20(Europe)/20230425_185758 https://github.com/Ragowit/redump-submissions/tree/main/PS5/B/Back%204%20Blood%20(Europe)/20230426_074014 **Expected behavior** I expect it to tell it's a BD-ROM-66, with two layers of ringcode information. **Additional context** To my knowledge, the only two valid Media Types for PS5 is BD-ROM-66 (two layers) and BD-ROM-100 (three layers).
claunia added the bug label 2026-01-29 16:17:59 +00:00
claunia commented 2026-01-29 16:18:00 +00:00
Author
Owner
Copy Link

@mnadareski commented on GitHub (Apr 26, 2023):

It looks like BD-66 and BD-100 use the identifier BDU instead of the original BDO for pressed discs. 088f1b8545 should fix this.

@mnadareski commented on GitHub (Apr 26, 2023): It looks like BD-66 and BD-100 use the identifier `BDU` instead of the original `BDO` for pressed discs. https://github.com/SabreTools/MPF/commit/088f1b8545b47a6b7adbf80fab4b4ab21cc3cce3 should fix this.
claunia commented 2026-01-29 16:18:01 +00:00
Author
Owner
Copy Link

@mnadareski commented on GitHub (Apr 26, 2023):

This may also be partially fixed by checking that identifier further into processing, implemented here 7c7509020f

@mnadareski commented on GitHub (Apr 26, 2023): This may also be partially fixed by checking that identifier further into processing, implemented here https://github.com/SabreTools/MPF/commit/7c7509020fcb33559f3eb49fb6d968e708e67001
claunia commented 2026-01-29 16:18:01 +00:00
Author
Owner
Copy Link

@Ragowit commented on GitHub (Apr 26, 2023):

Just did a new PS5 dump for "Death's Door". The Media Type output in submissionInfo is BD-ROM-50 when it should be BD-ROM-66.

Logs: https://github.com/Ragowit/redump-submissions/tree/main/PS5/D/Death's%20Door%20(Europe)/20230426_165104

This was done with 2.5-1112 win10-x64

@Ragowit commented on GitHub (Apr 26, 2023): Just did a new PS5 dump for "Death's Door". The Media Type output in submissionInfo is BD-ROM-50 when it should be BD-ROM-66. Logs: https://github.com/Ragowit/redump-submissions/tree/main/PS5/D/Death's%20Door%20(Europe)/20230426_165104 This was done with 2.5-1112 win10-x64
claunia commented 2026-01-29 16:18:02 +00:00
Author
Owner
Copy Link

@mnadareski commented on GitHub (Apr 26, 2023):

My local tests were relying on my assumption I was doing certain checks in only one place. The other place has been fixed as of 1ecf0ad1fa

@mnadareski commented on GitHub (Apr 26, 2023): My local tests were relying on my assumption I was doing certain checks in only one place. The other place has been fixed as of https://github.com/SabreTools/MPF/commit/1ecf0ad1fafccd87ccb71ac5ffa457f2b8299b9f
claunia commented 2026-01-29 16:18:02 +00:00
Author
Owner
Copy Link

@Ragowit commented on GitHub (Apr 26, 2023):

Tried 1113 Check on my Death's Door again, and it said BD-ROM-66 this time around.

@Ragowit commented on GitHub (Apr 26, 2023): Tried 1113 Check on my Death's Door again, and it said BD-ROM-66 this time around.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
duplicate
enhancement
good first issue
help wanted
invalid
pull-request
Mirrored from GitHub Pull Request
 question
regression
wontfix
No Label bug
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: SabreTools/MPF#526
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?