SabreTools/MPF
1
0
Fork 0
mirror of https://github.com/SabreTools/MPF.git synced 2026-02-03 21:29:27 +00:00
Code Issues 392 Packages Projects Releases 20 Wiki Activity

[Problem] System.NullReferenceException in Datfile generation #539

New Issue
Closed
opened 2026-01-29 16:18:11 +00:00 by claunia · 2 comments
claunia commented 2026-01-29 16:18:11 +00:00
Owner
Copy Link

Originally created by @bekoha on GitHub (May 18, 2023).

Originally assigned to: @mnadareski on GitHub.

Version
What version are you using?

  • WIP release (2.5-a31d894b)

Build
What runtime version are you using?

  • .NET Framework 4.8 running on (Windows 10.0.19045)

Describe the issue
Left the program running on attempting to dump a DVD of Deus Ex and came back to a window with red error

MPF defaulted to a lower speed than usual (24 is max speed that it generally auto-selected and here it for some reason picked 16 instead), that felt odd

DiscImageCreator has finished!
Running any additional tools... see log for output!
No external tools needed!
System.NullReferenceException: Object reference not set to an instance of an object.
   at MPF.Modules.BaseParameters.GenerateDatfile(Datafile datafile) in C:\projects\mpf\MPF.Modules\BaseParameters.cs:line 1094
   at MPF.Modules.DiscImageCreator.Parameters.GenerateSubmissionInfo(SubmissionInfo info, Options options, String basePath, Drive drive, Boolean includeArtifacts) in C:\projects\mpf\MPF.Modules\DiscImageCreator\Parameters.cs:line 399
   at MPF.Library.InfoTool.<ExtractOutputInformation>d__0.MoveNext() in C:\projects\mpf\MPF.Library\InfoTool.cs:line 99
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task)
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at System.Runtime.CompilerServices.TaskAwaiter`1.GetResult()
   at MPF.Library.DumpEnvironment.<VerifyAndSaveDumpOutput>d__40.MoveNext() in C:\projects\mpf\MPF.Library\DumpEnvironment.cs:line 342
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task)
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at System.Runtime.CompilerServices.TaskAwaiter`1.GetResult()
   at MPF.UI.ViewModels.MainViewModel.<StartDumping>d__61.MoveNext() in C:\projects\mpf\MPF\ViewModels\MainViewModel.cs:line 1237
Gathering submission information... please wait!
Extracting output information from output files...

Logs and .dat
dx1_logs.zip

DIC version 20230401 (20230401T144525), .bin filename was passed as an argument but resulting dump was an ISO, "rom name" row missing from the dat

Originally created by @bekoha on GitHub (May 18, 2023). Originally assigned to: @mnadareski on GitHub. **Version** What version are you using? - [x] WIP release (2.5-a31d894b) **Build** What runtime version are you using? - [x] .NET Framework 4.8 running on (Windows 10.0.19045) **Describe the issue** Left the program running on attempting to dump a DVD of Deus Ex and came back to a window with red error ~~MPF defaulted to a lower speed than usual (24 is max speed that it generally auto-selected and here it for some reason picked 16 instead), that felt odd~~ ```Executing DiscImageCreator... please wait! DiscImageCreator has finished! Running any additional tools... see log for output! No external tools needed! System.NullReferenceException: Object reference not set to an instance of an object. at MPF.Modules.BaseParameters.GenerateDatfile(Datafile datafile) in C:\projects\mpf\MPF.Modules\BaseParameters.cs:line 1094 at MPF.Modules.DiscImageCreator.Parameters.GenerateSubmissionInfo(SubmissionInfo info, Options options, String basePath, Drive drive, Boolean includeArtifacts) in C:\projects\mpf\MPF.Modules\DiscImageCreator\Parameters.cs:line 399 at MPF.Library.InfoTool.<ExtractOutputInformation>d__0.MoveNext() in C:\projects\mpf\MPF.Library\InfoTool.cs:line 99 --- End of stack trace from previous location where exception was thrown --- at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task) at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task) at System.Runtime.CompilerServices.TaskAwaiter`1.GetResult() at MPF.Library.DumpEnvironment.<VerifyAndSaveDumpOutput>d__40.MoveNext() in C:\projects\mpf\MPF.Library\DumpEnvironment.cs:line 342 --- End of stack trace from previous location where exception was thrown --- at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task) at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task) at System.Runtime.CompilerServices.TaskAwaiter`1.GetResult() at MPF.UI.ViewModels.MainViewModel.<StartDumping>d__61.MoveNext() in C:\projects\mpf\MPF\ViewModels\MainViewModel.cs:line 1237 Gathering submission information... please wait! Extracting output information from output files... ``` Logs and .dat [dx1_logs.zip](https://github.com/SabreTools/MPF/files/11510789/dx1_logs.zip) DIC version 20230401 (20230401T144525), .bin filename was passed as an argument but resulting dump was an ISO, "rom name" row missing from the dat
claunia added the bug label 2026-01-29 16:18:11 +00:00
claunia commented 2026-01-29 16:18:12 +00:00
Author
Owner
Copy Link

@mnadareski commented on GitHub (May 18, 2023):

The difference in speed was confirmed in Discord to be related to Stable vs. WIP build and should be discarded as a potential issue.

@mnadareski commented on GitHub (May 18, 2023): The difference in speed was confirmed in Discord to be related to Stable vs. WIP build and should be discarded as a potential issue.
claunia commented 2026-01-29 16:18:12 +00:00
Author
Owner
Copy Link

@mnadareski commented on GitHub (May 28, 2023):

The real issue was that the build of DIC being used was broken, but I am adding some safety around that method for the future anyway.

@mnadareski commented on GitHub (May 28, 2023): The real issue was that the build of DIC being used was broken, but I am adding some safety around that method for the future anyway.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
duplicate
enhancement
good first issue
help wanted
invalid
pull-request
Mirrored from GitHub Pull Request
 question
regression
wontfix
No Label bug
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: SabreTools/MPF#539
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?