[Problem] Doesn't detect an incomplete redumper DVD dump #545

Closed
opened 2026-01-29 16:18:16 +00:00 by claunia · 3 comments
Owner

Originally created by @DopefishJustin on GitHub (Jun 10, 2023).

Originally assigned to: @mnadareski on GitHub.

Version

  • WIP release 2.5-1126

Build
What runtime version are you using?

  • .NET Framework 4.8 running on Windows 10

Describe the issue
MPF does not seem to detect the redumper process terminating before it finishes, and proceeds as if the dump were successful.

To Reproduce
Steps to reproduce the behavior:

  1. Insert a DVD (I used an IBM PC compatible one)
  2. Scan for discs
  3. Select redumper as the dumping program
  4. Begin a dump
  5. Click X to close the redumper console window
  6. Note that MPF continues with the protection check and the submission info window

Expected behavior
Red text in the output window indicating a failure

Additional context
Works as expected when dumping a CD with redumper.

Originally created by @DopefishJustin on GitHub (Jun 10, 2023). Originally assigned to: @mnadareski on GitHub. **Version** - [x] WIP release 2.5-1126 **Build** What runtime version are you using? - [x] .NET Framework 4.8 running on Windows 10 **Describe the issue** MPF does not seem to detect the redumper process terminating before it finishes, and proceeds as if the dump were successful. **To Reproduce** Steps to reproduce the behavior: 1. Insert a DVD (I used an IBM PC compatible one) 2. Scan for discs 3. Select redumper as the dumping program 4. Begin a dump 5. Click X to close the redumper console window 6. Note that MPF continues with the protection check and the submission info window **Expected behavior** Red text in the output window indicating a failure **Additional context** Works as expected when dumping a CD with redumper.
claunia added the bug label 2026-01-29 16:18:16 +00:00
Author
Owner

@mnadareski commented on GitHub (Jun 10, 2023):

This is going to be difficult because the only thing that MPF looks for in a "completed" dump is one that contains all of the files that are necessary. If Redumper is creating all files off the bat, then it will pretty much always say that it's "complete". Not sure how to get around this, to be honest. Leaving it open, though, because it is an issue.

@mnadareski commented on GitHub (Jun 10, 2023): This is going to be difficult because the only thing that MPF looks for in a "completed" dump is one that contains all of the files that are necessary. If Redumper is creating all files off the bat, then it will pretty much always say that it's "complete". Not sure how to get around this, to be honest. Leaving it open, though, because it is an issue.
Author
Owner

@mnadareski commented on GitHub (Jun 23, 2023):

Possibly fixed by 8a5475380a

@mnadareski commented on GitHub (Jun 23, 2023): Possibly fixed by https://github.com/SabreTools/MPF/commit/8a5475380a0c318ed34b74724ea300d67d04411e
Author
Owner

@DopefishJustin commented on GitHub (Jun 23, 2023):

Confirmed fixed in 8a547538

@DopefishJustin commented on GitHub (Jun 23, 2023): Confirmed fixed in 8a547538
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: SabreTools/MPF#545