mirror of
https://github.com/SabreTools/MPF.git
synced 2026-02-03 21:29:27 +00:00
[Problem] Doesn't detect an incomplete redumper DVD dump #545
Reference in New Issue
Block a user
Delete Branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @DopefishJustin on GitHub (Jun 10, 2023).
Originally assigned to: @mnadareski on GitHub.
Version
Build
What runtime version are you using?
Describe the issue
MPF does not seem to detect the redumper process terminating before it finishes, and proceeds as if the dump were successful.
To Reproduce
Steps to reproduce the behavior:
Expected behavior
Red text in the output window indicating a failure
Additional context
Works as expected when dumping a CD with redumper.
@mnadareski commented on GitHub (Jun 10, 2023):
This is going to be difficult because the only thing that MPF looks for in a "completed" dump is one that contains all of the files that are necessary. If Redumper is creating all files off the bat, then it will pretty much always say that it's "complete". Not sure how to get around this, to be honest. Leaving it open, though, because it is an issue.
@mnadareski commented on GitHub (Jun 23, 2023):
Possibly fixed by
8a5475380a@DopefishJustin commented on GitHub (Jun 23, 2023):
Confirmed fixed in
8a547538