SabreTools/MPF
1
0
Fork 0
mirror of https://github.com/SabreTools/MPF.git synced 2026-02-03 21:29:27 +00:00
Code Issues 392 Packages Projects Releases 20 Wiki Activity

[Problem] The location of the DIC universal hash has been changed #552

New Issue
Closed
opened 2026-01-29 16:18:23 +00:00 by claunia · 8 comments
claunia commented 2026-01-29 16:18:23 +00:00
Owner
Copy Link

Originally created by @fuzz6001 on GitHub (Jun 22, 2023).

Originally assigned to: @mnadareski on GitHub.

DIC 20230606
The location of the universal hash seems to have changed from *_disc.txt to *_suppl.dat.

logs.zip

Universal Hash:

60d3548fe7dc7f53c3bc426405a5f02238b63e8e

*_suppl.dat:

<?xml version="1.0" encoding="UTF-8"?>
<!DOCTYPE datafile PUBLIC "-//Logiqx//DTD ROM Management Datafile//EN" "http://www.logiqx.com/Dats/datafile.dtd">
<datafile>
  <header>
    <name>-insert name-</name>
    <description>-insert description-</description>
    <version>-insert version-</version>
    <date>-insert date-</date>
    <author>-insert author-</author>
    <homepage>-insert homepage-</homepage>
    <url>-insert url-</url>
  </header>
  <game name="out">
    <category>Games</category>
    <description>out</description>
    <rom name="dump.img" size="642001920" crc="6c1b4e82" md5="460782a821d40a1ae9fdf05a63125570" sha1="34f485f83209ee3bba0cb25ccf5ceb727eeec6a3" />
    <rom name="dump (Track all).img" size="642587568" crc="5fc87d60" md5="7b557dff16fe0536893bdfaebd7db65b" sha1="60d3548fe7dc7f53c3bc426405a5f02238b63e8e" />
  </game>
</datafile>

from redumper log for reference:

non-zero  TOC sample range: [   -88200 .. +160500480]
non-zero data sample range: [    +8432 .. +160483205]
Universal Hash (SHA-1): 60d3548fe7dc7f53c3bc426405a5f02238b63e8e
Originally created by @fuzz6001 on GitHub (Jun 22, 2023). Originally assigned to: @mnadareski on GitHub. DIC 20230606 The location of the universal hash seems to have changed from *_disc.txt to *_suppl.dat. [logs.zip](https://github.com/SabreTools/MPF/files/11833451/logs.zip) Universal Hash: ``` 60d3548fe7dc7f53c3bc426405a5f02238b63e8e ``` *_suppl.dat: ```xml <?xml version="1.0" encoding="UTF-8"?> <!DOCTYPE datafile PUBLIC "-//Logiqx//DTD ROM Management Datafile//EN" "http://www.logiqx.com/Dats/datafile.dtd"> <datafile> <header> <name>-insert name-</name> <description>-insert description-</description> <version>-insert version-</version> <date>-insert date-</date> <author>-insert author-</author> <homepage>-insert homepage-</homepage> <url>-insert url-</url> </header> <game name="out"> <category>Games</category> <description>out</description> <rom name="dump.img" size="642001920" crc="6c1b4e82" md5="460782a821d40a1ae9fdf05a63125570" sha1="34f485f83209ee3bba0cb25ccf5ceb727eeec6a3" /> <rom name="dump (Track all).img" size="642587568" crc="5fc87d60" md5="7b557dff16fe0536893bdfaebd7db65b" sha1="60d3548fe7dc7f53c3bc426405a5f02238b63e8e" /> </game> </datafile> ``` from redumper log for reference: ``` non-zero TOC sample range: [ -88200 .. +160500480] non-zero data sample range: [ +8432 .. +160483205] Universal Hash (SHA-1): 60d3548fe7dc7f53c3bc426405a5f02238b63e8e ```
claunia added the bug label 2026-01-29 16:18:23 +00:00
claunia commented 2026-01-29 16:18:23 +00:00
Author
Owner
Copy Link

@mnadareski commented on GitHub (Jul 24, 2023):

I am going to be leaving this open but I am likely not going to be making any updates to DIC-specific pieces for the foreseeable future.

@mnadareski commented on GitHub (Jul 24, 2023): I am going to be leaving this open but I am likely not going to be making any updates to DIC-specific pieces for the foreseeable future.
claunia commented 2026-01-29 16:18:24 +00:00
Author
Owner
Copy Link

@Deterous commented on GitHub (Oct 12, 2023):

I may be doing something wrong, but I cannot get the hash in *_suppl.dat to include the Universal Hash.
All I get are the hashes of the *.img (concatenation of all the track files), not the universal hash.
Does DIC only create universal hashes for Plextor dumps?

@Deterous commented on GitHub (Oct 12, 2023): I may be doing something wrong, but I cannot get the hash in *_suppl.dat to include the Universal Hash. All I get are the hashes of the *.img (concatenation of all the track files), not the universal hash. Does DIC only create universal hashes for Plextor dumps?
claunia commented 2026-01-29 16:18:24 +00:00
Author
Owner
Copy Link

@Deterous commented on GitHub (Oct 12, 2023):

@fuzz6001 Can you try again with a disc that doesn't have a write offset of 0
I believe that the "Universal Hash" from DIC only matches redumper's Universal Hash because the disc does not have a write offset.
The hash in *_suppl.dat is just the *.img hash, which is different.

@Deterous commented on GitHub (Oct 12, 2023): @fuzz6001 Can you try again with a disc that doesn't have a write offset of 0 I believe that the "Universal Hash" from DIC only matches redumper's Universal Hash because the disc does not have a write offset. The hash in *_suppl.dat is just the *.img hash, which is different.
claunia commented 2026-01-29 16:18:24 +00:00
Author
Owner
Copy Link

@fuzz6001 commented on GitHub (Oct 12, 2023):

@Deterous

dic 20230606

<rom name="dump (Track all).img" size="549264912" crc="5d484c5c" md5="ed5af273afc5bcec95c0b7ba1d82b44d" sha1="12633787462c9aae126fa8a53fadb74dd4d4bb51" />

However, the offset must be specified manually.

cd g dump.bin 24 /c2 20 /q /ns /sf /a +14

redumper 204

non-zero  TOC sample range: [   -88200 .. +137169816]
non-zero data sample range: [    +5518 .. +137169830]
Universal Hash (SHA-1): 12633787462c9aae126fa8a53fadb74dd4d4bb51

Perfect Audio Offset (silence level: 10): [-18212 .. -12399]
moving data out of lead-out (difference: +14)
disc write offset: +14
@fuzz6001 commented on GitHub (Oct 12, 2023): @Deterous # dic 20230606 ```xml <rom name="dump (Track all).img" size="549264912" crc="5d484c5c" md5="ed5af273afc5bcec95c0b7ba1d82b44d" sha1="12633787462c9aae126fa8a53fadb74dd4d4bb51" /> ``` However, the offset must be specified manually. ``` cd g dump.bin 24 /c2 20 /q /ns /sf /a +14 ``` # redumper 204 ``` non-zero TOC sample range: [ -88200 .. +137169816] non-zero data sample range: [ +5518 .. +137169830] Universal Hash (SHA-1): 12633787462c9aae126fa8a53fadb74dd4d4bb51 Perfect Audio Offset (silence level: 10): [-18212 .. -12399] moving data out of lead-out (difference: +14) disc write offset: +14 ```
claunia commented 2026-01-29 16:18:24 +00:00
Author
Owner
Copy Link

@Deterous commented on GitHub (Oct 12, 2023):

Thank you for explaining it, I understand now.

I don't think MPF should be automatically reading DIC's universal hash if the user has to put the offset in the parameter box. Most dumpers will not do that, and MPF will then place incorrect Universal Hashes into the submission info.

If a user wants to use DIC to calculate the Universal Hash like you have above, they can place it into the Disc Information Window manually.

@Deterous commented on GitHub (Oct 12, 2023): Thank you for explaining it, I understand now. I don't think MPF should be automatically reading DIC's universal hash if the user has to put the offset in the parameter box. Most dumpers will not do that, and MPF will then place incorrect Universal Hashes into the submission info. If a user wants to use DIC to calculate the Universal Hash like you have above, they can place it into the Disc Information Window manually.
claunia commented 2026-01-29 16:18:24 +00:00
Author
Owner
Copy Link

@fuzz6001 commented on GitHub (Oct 12, 2023):

I am just reporting a change in location.
I do not care if the DIC universal hash does not appear.
This issue can be closed at any time.

@fuzz6001 commented on GitHub (Oct 12, 2023): I am just reporting a change in location. I do not care if the DIC universal hash does not appear. This issue can be closed at any time.
claunia commented 2026-01-29 16:18:25 +00:00
Author
Owner
Copy Link

@Deterous commented on GitHub (Oct 12, 2023):

The solution to this 'issue' may be to remove the relevant code, as it does not work anyway with the packaged DIC version.
I will suggest the change, thank you for the report.

@Deterous commented on GitHub (Oct 12, 2023): The solution to this 'issue' may be to remove the relevant code, as it does not work anyway with the packaged DIC version. I will suggest the change, thank you for the report.
claunia commented 2026-01-29 16:18:25 +00:00
Author
Owner
Copy Link

@fuzz6001 commented on GitHub (Oct 12, 2023):

The solution to this 'issue' may be to remove the relevant code, as it does not work anyway with the packaged DIC version.

Yes, I think that is the best solution 👍

@fuzz6001 commented on GitHub (Oct 12, 2023): > The solution to this 'issue' may be to remove the relevant code, as it does not work anyway with the packaged DIC version. Yes, I think that is the best solution 👍
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
duplicate
enhancement
good first issue
help wanted
invalid
pull-request
Mirrored from GitHub Pull Request
 question
regression
wontfix
No Label bug
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: SabreTools/MPF#552
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?