[Problem] [Audio CD] Duplication of Universal Hash when verifying an Audio CD #559

New Issue

Closed

opened 2026-01-29 16:18:29 +00:00 by claunia · 0 comments

claunia commented 2026-01-29 16:18:29 +00:00

Owner

Copy Link

Originally created by @mictlantecuhtle on GitHub (Jul 12, 2023).

Originally assigned to: @mnadareski on GitHub.

Version

• WIP release (v2.5-12fd55e7)

Build
What runtime version are you using?

• .NET Framework 4.8 running on (Windows 10)

Describe the issue
Functionally similar to https://github.com/SabreTools/MPF/issues/512

When verifying an Audio CD, the Universal Hash information is duplicated - pulled from the existing comments and added from the new dump: <b>Universal Hash (SHA-1)</b>: d9fc2f1148cad8c4ad933629d6df418d699d3466, d9fc2f1148cad8c4ad933629d6df418d699d3466

Also occurring, although of less concern as there is clear separation between the elements, any existing non-zero data start information in comments is pulled into the !submissionInfo.txt

<b>Ring non-zero data start</b>: +5869
<b>Ring #7 non-zero data start</b>: +5869

To Reproduce

1. Ensure MPF has your correct Redump login details
2. Dump an Audio CD that you know to be a verification of one with Universal Hash/non-zero data start information in the comments

Expected behavior
Universal Hash information should come only from the dump/logs, not be pulled from the comments. Possibly existing non-zero data start information should also not be pulled from comments.

Originally created by @mictlantecuhtle on GitHub (Jul 12, 2023). Originally assigned to: @mnadareski on GitHub. **Version** - [X] WIP release (v2.5-12fd55e7) **Build** What runtime version are you using? - [X] .NET Framework 4.8 running on (Windows 10) **Describe the issue** Functionally similar to https://github.com/SabreTools/MPF/issues/512 When verifying an Audio CD, the Universal Hash information is duplicated - pulled from the existing comments and added from the new dump: `<b>Universal Hash (SHA-1)</b>: d9fc2f1148cad8c4ad933629d6df418d699d3466, d9fc2f1148cad8c4ad933629d6df418d699d3466` Also occurring, although of less concern as there is clear separation between the elements, any existing non-zero data start information in comments is pulled into the !submissionInfo.txt ``` <b>Ring non-zero data start</b>: +5869 <b>Ring #7 non-zero data start</b>: +5869 ``` **To Reproduce** 1. Ensure MPF has your correct Redump login details 2. Dump an Audio CD that you know to be a verification of one with Universal Hash/non-zero data start information in the comments **Expected behavior** Universal Hash information should come only from the dump/logs, not be pulled from the comments. Possibly existing non-zero data start information should also not be pulled from comments.

claunia added the bug label 2026-01-29 16:18:29 +00:00

claunia closed this issue 2026-01-29 16:18:29 +00:00

Sign in to join this conversation.

No Branch/Tag Specified

Branches Tags

master

rolling

3.6.0

3.5.0

3.4.2

3.4.1

3.4.0

3.3.3

3.3.2

3.3.1

3.3.0

3.2.4

3.2.3

3.2.2

3.2.1

3.2.0

3.1.9

3.1.8

3.1.7

3.1.6

3.1.5

3.1.4

3.1.3

3.1.2

check-rolling

ui-rolling

3.1.1

3.1.0

3.0.3

3.0.2

3.0.1

3.0.0

2.7.5

2.7.4

2.7.3

2.7.2

2.7.1

2.7.0

2.6.6

2.6.5

2.6.4

2.6.3

2.6.2

2.6.1

2.6

2.5

2.4

2.3

2.2

2.1

2.0

1.18

1.17.1

1.17

1.16.1

1.16

1.15

1.14

1.13

1.12.2

1.12.1

1.12

1.11

1.10

1.07

1.06

1.05.1

1.05

1.04b

1.04a

1.04

1.03

1.02b

1.02

1.01d

1.01c

1.01b

Labels

Clear labels

bug

duplicate

enhancement

good first issue

help wanted

invalid

pull-request

Mirrored from GitHub Pull Request

question

regression

wontfix

No Label bug

Milestone

No items

No Milestone

Projects

Clear projects

No project

Assignees

Clear assignees

claunia

No Assignees

1 Participants

Notifications

Subscribe

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: SabreTools/MPF#559