SabreTools/MPF
1
0
Fork 0
mirror of https://github.com/SabreTools/MPF.git synced 2026-02-07 21:30:16 +00:00
Code Issues 392 Packages Projects Releases 20 Wiki Activity

[Problem] Able to select Redumper for HD DVD #563

New Issue
Closed
opened 2026-01-29 16:18:33 +00:00 by claunia · 2 comments
claunia commented 2026-01-29 16:18:33 +00:00
Owner
Copy Link

Originally created by @FoxhackDN on GitHub (Jul 14, 2023).

Originally assigned to: @mnadareski on GitHub.

Version
What version are you using?

  • Stable release (version here)
  • WIP release 2.5.1149

Build
What runtime version are you using?

  • .NET Framework 4.8 running on (Operating System)
  • .NET 6.0 running on (Operating System)

Describe the issue
If you select HD DVD as the system, then select redumper as the dumping program, the dump button is grayed out. That's proper behavior.

If you select a different supported dumping tool for the format (DIC or Aaru), the default command line parameters are loaded and the dump button works again. Also proper behavior.

But if you go and select redumper, the command line parameters box is blanked out, AND the dump button works. If you press it, nothing happens, Redumper says "Media and system combination not supported for Redumper". So the only bug here is the button not being grayed out like it's supposed to.

To Reproduce
Steps to reproduce the behavior:

  1. Select Redumper
  2. Change media to HD DVD Video
  3. Change dumping tool from the selection box to DIC or aaru
  4. Change it back to Redumper

Expected behavior
The button should be grayed out

Screenshots
If applicable, add screenshots to help explain your problem.

Additional context
Add any other context about the problem here.

Originally created by @FoxhackDN on GitHub (Jul 14, 2023). Originally assigned to: @mnadareski on GitHub. **Version** What version are you using? - [ ] Stable release (version here) - [X] WIP release 2.5.1149 **Build** What runtime version are you using? - [X] .NET Framework 4.8 running on (Operating System) - [ ] .NET 6.0 running on (Operating System) **Describe the issue** If you select HD DVD as the system, then select redumper as the dumping program, the dump button is grayed out. That's proper behavior. If you select a different supported dumping tool for the format (DIC or Aaru), the default command line parameters are loaded and the dump button works again. Also proper behavior. But if you go and select redumper, the command line parameters box is blanked out, AND the dump button works. If you press it, nothing happens, Redumper says "Media and system combination not supported for Redumper". So the only bug here is the button not being grayed out like it's supposed to. **To Reproduce** Steps to reproduce the behavior: 1. Select Redumper 2. Change media to HD DVD Video 3. Change dumping tool from the selection box to DIC or aaru 4. Change it back to Redumper **Expected behavior** The button should be grayed out **Screenshots** If applicable, add screenshots to help explain your problem. **Additional context** Add any other context about the problem here.
claunia added the bug label 2026-01-29 16:18:33 +00:00
claunia commented 2026-01-29 16:18:34 +00:00
Author
Owner
Copy Link

@FoxhackDN commented on GitHub (Oct 11, 2023):

Updating for 2.7.0, since recent changes have fixed some things:

  1. Set the Default System to "No System Selected", restart MPF if needed.
  2. You should see there's no default system selected, so the media type is grayed out.
  3. Select Redumper
  4. Change system to HD DVD Video, this will change the media type to HD-DVD Video as well.
  5. The dumping box is active, but the parameters box is empty.

If you click on "Start Dumping", MPF will create a folder in the path shown on the output path as normal but no files will be generated, because "Media and system combination not supported for Redumper" (which is the correct behavior.)

This also seems to happen if you have a default system selected in the options and you change to HD DVD Video.

@FoxhackDN commented on GitHub (Oct 11, 2023): Updating for 2.7.0, since recent changes have fixed some things: 1. Set the Default System to "No System Selected", restart MPF if needed. 2. You should see there's no default system selected, so the media type is grayed out. 3. Select Redumper 4. Change system to HD DVD Video, this will change the media type to HD-DVD Video as well. 5. The dumping box is active, but the parameters box is empty. If you click on "Start Dumping", MPF will create a folder in the path shown on the output path as normal but no files will be generated, because "Media and system combination not supported for Redumper" (which is the correct behavior.) This also seems to happen if you have a default system selected in the options and you change to HD DVD Video.
claunia commented 2026-01-29 16:18:35 +00:00
Author
Owner
Copy Link

@mnadareski commented on GitHub (Oct 13, 2023):

Should be fixed by ae326c1d2f and e8b0b3efaa

@mnadareski commented on GitHub (Oct 13, 2023): Should be fixed by https://github.com/SabreTools/MPF/commit/ae326c1d2f9e973db7416ec01c65a7a48bbb2815 and https://github.com/SabreTools/MPF/commit/e8b0b3efaa463b0a726ec354d40b72aa942cc22c
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
duplicate
enhancement
good first issue
help wanted
invalid
pull-request
Mirrored from GitHub Pull Request
 question
regression
wontfix
No Label bug
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: SabreTools/MPF#563
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?