mirror of
https://github.com/SabreTools/MPF.git
synced 2026-02-03 21:29:27 +00:00
MPF.check does not process PSP dumps from UIC correctly #584
Reference in New Issue
Block a user
Delete Branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @sadikyo on GitHub (Aug 12, 2023).
Originally assigned to: @mnadareski on GitHub.
What version are you using?
Build
Describe the issue
When using MPF.check on a PSP dump from UmdImageCreator, the process fails because it looks for a _drive.txt file. This log is not produced by UIC.
To Reproduce
Dump PSP umd with UIC, then run MPF.check
Expected behavior
Process just like normal
Additional context
I suppose one could create a dummy _drive.txt file, but it'd be nice if the -u UmdImageCreator parameter would correct the need for a _drive.txt file in order to process correctly.
@mnadareski commented on GitHub (Aug 12, 2023):
What version of UIC are you using? Also, can you share the commandline you used to run MPF.Check?
@sadikyo commented on GitHub (Aug 12, 2023):
It looks like I was using v1.3. I'll update to 1.5 and try that.
The command I used is:
mpf.check umd psp -u umdimagecreator [output path]
@mnadareski commented on GitHub (Aug 13, 2023):
Okay, I don't see that file being explicitly used for anything except being zipped up, so I'll remove it as required.
@sadikyo commented on GitHub (Aug 13, 2023):
It looks like 1.5 version does produce the _drive.txt, but older versions don't. So if it isn't required, that seems good anyway. I'm assuming even if you change this, it will still zip it up?
@mnadareski commented on GitHub (Aug 13, 2023):
Yep, it just marks the file as not required on detection but will still zip it up and include in artifacts.