mirror of
https://github.com/SabreTools/MPF.git
synced 2026-02-03 21:29:27 +00:00
[Problem] MPF is not always accurately detecting the region from PS2 Discs. I suggest this feature be altered or removed. #591
Reference in New Issue
Block a user
Delete Branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @sadikyo on GitHub (Aug 22, 2023).
Originally assigned to: @mnadareski on GitHub.
Build
What runtime version are you using?
Describe the issue
MPF is detecting PS2 Region from the serial, which is not always accurate, especially for non-USA regions. For example, SLPM 64537 "looks" like a Japan region and MPF detects it as such simply based on the serial, but this is actually a Korea region disc. The same issue occurs for some Asia region discs as well.
We could alter / refine the detection process, if I knew exactly the model you were using for determining region. There are some subsets of serials that do more commonly belong to certain regions. For example, SLPM 64xxx is typically korea. I imagine your current detection is more broad and might assume either SLPM or SLPM 6 or something, is Japan. I am happy to help here or we could investigate more accurate detection methods.
To Reproduce
Dump PS2 disc, see what region MPF detects.
Expected behavior
Either no detection or an accurate region
@sadikyo commented on GitHub (Aug 22, 2023):
The other problem with serial-based detection, is that if you are using internal serial (my assumption?), if there is a different region that matches the Japan region, that verification / other disc would also be misdetected. There are several cases where multiple different regions match and have the same internal serial.
@mnadareski commented on GitHub (Aug 27, 2023):
All automatic detections, from media and system type to region, are based on conventions and may not always be accurate. I place the onus of verification on the users. As previously discussed, I cannot have a "VERIFY THIS" tag on the region because of the strict set of regions and odd region codes used by Redump. I'm open to discuss this, but as I see it, this is a valid first-pass way of detecting regions.
@sadikyo commented on GitHub (Aug 30, 2023):
Can you provide more information or point me to the direction of the convention it is currently using to detect the region for PS2 media? I may be able to help improve it (using the same system you are using now).
@mnadareski commented on GitHub (Aug 30, 2023):
https://github.com/SabreTools/MPF/blob/master/MPF.Modules/BaseParameters.cs#L1840
@Deterous commented on GitHub (Aug 30, 2023):
If I am reading it correctly, this region detection occurs automatically using internal serials, and so region will be incorrect for some discs even if cases such as Korean SLPM-64xxx are accounted for, as the internal serial may be in the Japan range.
Where the internal serial does match printed disc serial, then the improved detection would work.
@mnadareski commented on GitHub (Aug 30, 2023):
You are correct, hence my comment above about "first pass attempt". There's no way for MPF to read the external serial of a disc or reasonably detect things like languages to make better guesses.
@Deterous commented on GitHub (Aug 30, 2023):
I've made a PR (#542) with my suggested changes, which includes ignoring S_P_ serials that should solve sadikyo's issue with this, as it forces the user to select the correct region rather than leaving it as Japan. The other cases (Europe, USA, etc) are okay to leave alone (for PS2 at least) as they not have region conflicts like S_P_ serials do (except for rare circumstances such as Beta/Preview editions).