SabreTools/MPF
1
0
Fork 0
mirror of https://github.com/SabreTools/MPF.git synced 2026-02-04 05:35:52 +00:00
Code Issues 392 Packages Projects Releases 20 Wiki Activity

[Problem] MPF does not default to .aaruf extension when using Aaru #596

New Issue
Closed
opened 2026-01-29 16:19:05 +00:00 by claunia · 7 comments
claunia commented 2026-01-29 16:19:05 +00:00
Owner
Copy Link

Originally created by @CookiePLMonster on GitHub (Aug 23, 2023).

Originally assigned to: @mnadareski on GitHub.

Version
What version are you using?

  • Stable release (2.6.3) - at the time of submitting this report it's equivalent to the WIP release

Build
What runtime version are you using?

  • .NET Framework 4.8 running on Windows 10

Describe the issue
Aaru requires that the output file extension is .aaruf and not .bin. Supplying a path with a wrong extension will make Aaru refuse to dump the disc. I vaguely recall that MPF used to supply a correct extension when selecting Aaru, but this is not the case anymore.

To Reproduce
Steps to reproduce the behavior:

  1. Open MPF.
  2. Set Aaru as the dumping program. Observe that the output path in the Parameters field points to a .bin file.
  3. Start dumping, notice Aaru refuses to dump the file.
  4. Change the output path to point to an .aaruf file and start dumping again.
  5. Notice dumping proceeds as expected.

Expected behavior
MPF defaults to a correct .aaruf extension when using Aaru as the dumping program.

Originally created by @CookiePLMonster on GitHub (Aug 23, 2023). Originally assigned to: @mnadareski on GitHub. **Version** What version are you using? - [x] Stable release (2.6.3) - at the time of submitting this report it's equivalent to the WIP release **Build** What runtime version are you using? - [x] .NET Framework 4.8 running on **Windows 10** **Describe the issue** Aaru requires that the output file extension is `.aaruf` and not `.bin.` Supplying a path with a wrong extension will make Aaru refuse to dump the disc. I vaguely recall that MPF used to supply a correct extension when selecting Aaru, but this is not the case anymore. **To Reproduce** Steps to reproduce the behavior: 1. Open MPF. 2. Set Aaru as the dumping program. Observe that the output path in the **Parameters** field points to a `.bin` file. 3. Start dumping, notice Aaru refuses to dump the file. 4. Change the output path to point to an `.aaruf` file and start dumping again. 5. Notice dumping proceeds as expected. **Expected behavior** MPF defaults to a correct `.aaruf` extension when using Aaru as the dumping program.
claunia added the bug label 2026-01-29 16:19:05 +00:00
claunia commented 2026-01-29 16:19:06 +00:00
Author
Owner
Copy Link

@mnadareski commented on GitHub (Aug 27, 2023):

Please expand on point 2. Do you mean "change to Aaru using the drop-box in the main UI" or "change to Aaru using the Options menu"? This is a critical difference.

@mnadareski commented on GitHub (Aug 27, 2023): Please expand on point 2. Do you mean "change to Aaru using the drop-box in the main UI" or "change to Aaru using the Options menu"? This is a critical difference.
claunia commented 2026-01-29 16:19:06 +00:00
Author
Owner
Copy Link

@mnadareski commented on GitHub (Aug 27, 2023):

If it is the former, try d92a1d566d to see if it fixes your issues.

@mnadareski commented on GitHub (Aug 27, 2023): If it is the former, try https://github.com/SabreTools/MPF/commit/d92a1d566dc14ca90878fed030d3456e39612bcf to see if it fixes your issues.
claunia commented 2026-01-29 16:19:07 +00:00
Author
Owner
Copy Link

@CookiePLMonster commented on GitHub (Aug 28, 2023):

Please expand on point 2. Do you mean "change to Aaru using the drop-box in the main UI" or "change to Aaru using the Options menu"? This is a critical difference.

Yes, it is the former, apologies for not clarifying.

However, on the latest WIP build (d92a1d566d) the issue still persists. Changing to Aaru using the dropdown in the main UI does not change the extension from .bin to .aaruf. Ideally, the extension (and only the extension) should change regardless of whether the output path has been left at default, or modified by the user beforehand.

@CookiePLMonster commented on GitHub (Aug 28, 2023): > Please expand on point 2. Do you mean "change to Aaru using the drop-box in the main UI" or "change to Aaru using the Options menu"? This is a critical difference. Yes, it is the former, apologies for not clarifying. However, on the latest WIP build (d92a1d566dc14ca90878fed030d3456e39612bcf) the issue still persists. Changing to Aaru using the dropdown in the main UI does not change the extension from `.bin` to `.aaruf`. Ideally, the extension (and only the extension) should change regardless of whether the output path has been left at default, or modified by the user beforehand.
claunia commented 2026-01-29 16:19:07 +00:00
Author
Owner
Copy Link

@mnadareski commented on GitHub (Aug 28, 2023):

Try out 0912b78568 to see if it fixes your issues.

@mnadareski commented on GitHub (Aug 28, 2023): Try out https://github.com/SabreTools/MPF/commit/0912b78568cd41a8b060fcba2699494450cb3c3e to see if it fixes your issues.
claunia commented 2026-01-29 16:19:07 +00:00
Author
Owner
Copy Link

@CookiePLMonster commented on GitHub (Aug 28, 2023):

Try out 0912b78 to see if it fixes your issues.

Almost - the order of operations is wrong, because now changing the dumping program influences not the current extension, but the future one - as if it first checked the dumping program, then the dropdown option change took effect.

Try it with the following:

  1. Start with DIC selected - gives an extension .bin.
  2. Switch to Aaru - extension stays at .bin.
  3. Switch to dd, redumper or DIC - extension changes to .aaruf.
@CookiePLMonster commented on GitHub (Aug 28, 2023): > Try out [0912b78](https://github.com/SabreTools/MPF/commit/0912b78568cd41a8b060fcba2699494450cb3c3e) to see if it fixes your issues. Almost - the order of operations is wrong, because now changing the dumping program influences not the current extension, but the **future** one - as if it first checked the dumping program, then the dropdown option change took effect. Try it with the following: 1. Start with DIC selected - gives an extension `.bin`. 2. Switch to Aaru - extension stays at `.bin.` 3. Switch to dd, redumper or DIC - extension changes to `.aaruf`.
claunia commented 2026-01-29 16:19:08 +00:00
Author
Owner
Copy Link

@mnadareski commented on GitHub (Aug 28, 2023):

You mean "past" not "future". Try out 98a30e6558

@mnadareski commented on GitHub (Aug 28, 2023): You mean "past" not "future". Try out https://github.com/SabreTools/MPF/commit/98a30e65583cd989352126edace5b69532ee0ab1
claunia commented 2026-01-29 16:19:08 +00:00
Author
Owner
Copy Link

@CookiePLMonster commented on GitHub (Aug 28, 2023):

I meant "future" as in "the current selected UI option is going to influence the next (future) output path", which indeed is equivalent to "the past UI option influenced the current output path".

Regardless, it works fine now. Thanks!

@CookiePLMonster commented on GitHub (Aug 28, 2023): I meant "future" as in "the current selected UI option is going to influence the next (future) output path", which indeed is equivalent to "the past UI option influenced the current output path". Regardless, it works fine now. Thanks!
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
duplicate
enhancement
good first issue
help wanted
invalid
pull-request
Mirrored from GitHub Pull Request
 question
regression
wontfix
No Label bug
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: SabreTools/MPF#596
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?