SabreTools/MPF
1
0
Fork 0
mirror of https://github.com/SabreTools/MPF.git synced 2026-02-04 05:35:52 +00:00
Code Issues 392 Packages Projects Releases 20 Wiki Activity

[Problem] MPF misattributes issue numbers as Disc Title #598

New Issue
Closed
opened 2026-01-29 16:19:11 +00:00 by claunia · 7 comments
claunia commented 2026-01-29 16:19:11 +00:00
Owner
Copy Link

Originally created by @CookiePLMonster on GitHub (Aug 30, 2023).

Originally assigned to: @mnadareski on GitHub.

If all of those fail, then continue...

Version
What version are you using?

Build
What runtime version are you using?

  • .NET Framework 4.8 running on Windows 10

Describe the issue
Many covermounts have their issue numbers written in parenthesis as part of the Title. When pre-filling !submissioninfo.txt with verification data from Redump, MPF (and MPF.Check) misattributes this part of the Title as Disc Title.

My test case is Kaczor Donald 51-52/2006 (581): http://redump.org/disc/47147/
Its current datname is Kaczor Donald 51-52-2006 (581) (Poland), because (581) is part of the Title. However, with MPF moving it to the Disc Title, a submission processed exactly as MPF suggests would be datted as Kaczor Donald 51-52-2006 (Poland) (581).

This has been pointed out on Redump when a fix was being processed.

To Reproduce

  1. Take a verification of any submission that has an issue number in the title. In this example it's http://redump.org/disc/47147.
  2. Run MPF.Check on the dump, or dump it again via MPF.
  3. Notice that the issue number (in this case, 581) has been pre-filled as Disc Title:
Common Disc Info:
    Title: Kaczor Donald 51-52/2006
    Foreign Title (Non-latin): Mad Tracks
    Disc Number / Letter: (OPTIONAL)
    Disc Title: 581
    System: IBM PC compatible
    Media Type: CD-ROM
    Category: Coverdiscs
    Fully Matching ID: 47147
    Region: Poland
    Languages: SILENCE! (CHANGE THIS)
    Disc Serial: (REQUIRED, IF EXISTS)

Expected behavior
The issue number should stay part of the Title.

Originally created by @CookiePLMonster on GitHub (Aug 30, 2023). Originally assigned to: @mnadareski on GitHub. If all of those fail, then continue... **Version** What version are you using? - [x] WIP release (MPF.Check 6baaf132a7c47ab27d7ca4d0c1c7939702c17806) **Build** What runtime version are you using? - [x] .NET Framework 4.8 running on **Windows 10** **Describe the issue** Many covermounts have their issue numbers written in parenthesis as part of the Title. When pre-filling `!submissioninfo.txt` with verification data from Redump, MPF (and MPF.Check) misattributes this part of the Title as Disc Title. My test case is **Kaczor Donald 51-52/2006 (581)**: <http://redump.org/disc/47147/> Its current datname is `Kaczor Donald 51-52-2006 (581) (Poland)`, because `(581)` is part of the Title. However, with MPF moving it to the Disc Title, a submission processed exactly as MPF suggests would be datted as `Kaczor Donald 51-52-2006 (Poland) (581)`. This [has been pointed out on Redump](http://forum.redump.org/post/111489/#p111489) when a fix was being processed. **To Reproduce** 1. Take a verification of any submission that has an issue number in the title. In this example it's <http://redump.org/disc/47147>. 2. Run `MPF.Check` on the dump, or dump it again via `MPF`. 3. Notice that the issue number (in this case, `581`) has been pre-filled as Disc Title: ``` Common Disc Info: Title: Kaczor Donald 51-52/2006 Foreign Title (Non-latin): Mad Tracks Disc Number / Letter: (OPTIONAL) Disc Title: 581 System: IBM PC compatible Media Type: CD-ROM Category: Coverdiscs Fully Matching ID: 47147 Region: Poland Languages: SILENCE! (CHANGE THIS) Disc Serial: (REQUIRED, IF EXISTS) ``` **Expected behavior** The issue number should stay part of the Title.
claunia added the enhancementbug labels 2026-01-29 16:19:11 +00:00
claunia commented 2026-01-29 16:19:12 +00:00
Author
Owner
Copy Link

@mnadareski commented on GitHub (Aug 30, 2023):

There's literally no way to tell since they're formatted identically. I can't fix this.

@mnadareski commented on GitHub (Aug 30, 2023): There's literally no way to tell since they're formatted identically. I can't fix this.
claunia commented 2026-01-29 16:19:12 +00:00
Author
Owner
Copy Link

@CookiePLMonster commented on GitHub (Aug 30, 2023):

Do you parse those from datnames or other data? If it is datnames, then a rule that Disc Letter and/or Disc Title must be after the Region might help resolve this.

@CookiePLMonster commented on GitHub (Aug 30, 2023): Do you parse those from datnames or other data? If it is datnames, then a rule that Disc Letter and/or Disc Title must be after the Region might help resolve this.
claunia commented 2026-01-29 16:19:12 +00:00
Author
Owner
Copy Link

@mnadareski commented on GitHub (Aug 30, 2023):

Everything it parses is direct from the page, so not the name in the DAT, unfortunately.

@mnadareski commented on GitHub (Aug 30, 2023): Everything it parses is direct from the page, so not the name in the DAT, unfortunately.
claunia commented 2026-01-29 16:19:13 +00:00
Author
Owner
Copy Link

@CookiePLMonster commented on GitHub (Aug 30, 2023):

I see, so you effectively receive what is equivalent to Redump's display name, e.g. Kaczor Donald 52-53/2005 (529). I can see that being problematic indeed, with the only idea being maybe to filter out Disc Titles that are numeric only not to be treated as Disc Titles.

@CookiePLMonster commented on GitHub (Aug 30, 2023): I see, so you effectively receive what is equivalent to Redump's display name, e.g. `Kaczor Donald 52-53/2005 (529)`. I can see that being problematic indeed, with the only idea being maybe to filter out Disc Titles that are numeric only not to be treated as Disc Titles.
claunia commented 2026-01-29 16:19:13 +00:00
Author
Owner
Copy Link

@mnadareski commented on GitHub (Aug 30, 2023):

I cannot guarantee that a disc title would not be purely numeric at any point.

@mnadareski commented on GitHub (Aug 30, 2023): I cannot guarantee that a disc title would not be purely numeric at any point.
claunia commented 2026-01-29 16:19:13 +00:00
Author
Owner
Copy Link

@CookiePLMonster commented on GitHub (Aug 30, 2023):

True - but you are trading off a relatively frequent false positive (issue number treated as a Disc Title) into a much more uncommon false negative (Disc Title treated as a part of the Title). It's still a win.

@CookiePLMonster commented on GitHub (Aug 30, 2023): True - but you are trading off a relatively frequent false positive (issue number treated as a Disc Title) into a much more uncommon false negative (Disc Title treated as a part of the Title). It's still a win.
claunia commented 2026-01-29 16:19:13 +00:00
Author
Owner
Copy Link

@mnadareski commented on GitHub (Aug 30, 2023):

I'll consider it.

@mnadareski commented on GitHub (Aug 30, 2023): I'll consider it.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
duplicate
enhancement
good first issue
help wanted
invalid
pull-request
Mirrored from GitHub Pull Request
 question
regression
wontfix
No Label bug enhancement
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: SabreTools/MPF#598
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?