SabreTools/MPF
1
0
Fork 0
mirror of https://github.com/SabreTools/MPF.git synced 2026-02-03 21:29:27 +00:00
Code Issues 392 Packages Projects Releases 20 Wiki Activity

[Problem] Dumping time in !submissionInfo.txt wrongly formatted #606

New Issue
Closed
opened 2026-01-29 16:19:18 +00:00 by claunia · 2 comments
claunia commented 2026-01-29 16:19:18 +00:00
Owner
Copy Link

Originally created by @JohnVeness on GitHub (Sep 11, 2023).

Originally assigned to: @mnadareski on GitHub.

Version
What version are you using?

  • Stable release (version 2.6.3)
  • WIP release (version here)

Build

  • .NET Framework 4.8 running on (Windows 10)
  • .NET 6.0 running on (Operating System)

Describe the issue
The newly added dumping date in the log (introduced in commit 56e91bf177) has incorrect formatting for the time portion. Currently it is "hh:mm:ss" but should be "HH:mm:ss". The current formatting means that 6 o'clock in the evening UTC is showing as 06:00:00 instead of 18:00:00 as it should be.

To Reproduce
Steps to reproduce the behavior:

  1. Dump a disc while after 1 pm in UTC
  2. Check !submissionInfo.txt
  3. Scroll to bottom of file and look at Date field

Expected behavior
The time portion of the date should have 13 to 23 in the hour part.

Additional context
I haven't checked the WIP version but the relevant code hasn't changed since 2.6.3 as far as I can see.

Originally created by @JohnVeness on GitHub (Sep 11, 2023). Originally assigned to: @mnadareski on GitHub. **Version** What version are you using? - [x] Stable release (version 2.6.3) - [ ] WIP release (version here) **Build** - [x] .NET Framework 4.8 running on (Windows 10) - [ ] .NET 6.0 running on (Operating System) **Describe the issue** The newly added dumping date in the log (introduced in commit https://github.com/SabreTools/MPF/commit/56e91bf177df676fd4d47ec24255c397b16db163) has incorrect formatting for the time portion. Currently it is "hh:mm:ss" but should be "HH:mm:ss". The current formatting means that 6 o'clock in the evening UTC is showing as 06:00:00 instead of 18:00:00 as it should be. **To Reproduce** Steps to reproduce the behavior: 1. Dump a disc while after 1 pm in UTC 2. Check !submissionInfo.txt 3. Scroll to bottom of file and look at Date field **Expected behavior** The time portion of the date should have 13 to 23 in the hour part. **Additional context** I haven't checked the WIP version but the relevant code hasn't changed since 2.6.3 as far as I can see.
claunia added the bug label 2026-01-29 16:19:18 +00:00
claunia commented 2026-01-29 16:19:20 +00:00
Author
Owner
Copy Link

@JohnVeness commented on GitHub (Sep 11, 2023):

By the way, I don't mind writing a PR for this if it helps, basically changing all "hh" to "HH" in code touched by that commit, but I won't be able to build/test it.

@JohnVeness commented on GitHub (Sep 11, 2023): By the way, I don't mind writing a PR for this if it helps, basically changing all "hh" to "HH" in code touched by that commit, but I won't be able to build/test it.
claunia commented 2026-01-29 16:19:20 +00:00
Author
Owner
Copy Link

@Deterous commented on GitHub (Sep 27, 2023):

Fixed by #551

@Deterous commented on GitHub (Sep 27, 2023): Fixed by #551
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
duplicate
enhancement
good first issue
help wanted
invalid
pull-request
Mirrored from GitHub Pull Request
 question
regression
wontfix
No Label bug
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: SabreTools/MPF#606
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?