mirror of
https://github.com/SabreTools/MPF.git
synced 2026-02-03 21:29:27 +00:00
[Problem] MPF Doesn't seem to correctly pull EDC Yes/No information for PS1 Discs dumped with redumper #610
Reference in New Issue
Block a user
Delete Branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @sadikyo on GitHub (Sep 29, 2023).
Originally assigned to: @mnadareski on GitHub.
Describe the issue
When dumping PS1 discs with redumper, redumper correctly detects whether EDC should be marked Yes or No. This information is not being pulled correctly into MPF.
Additional context
In the redumper log, it is in this section:
CD-ROM [SLPM-80582 (Track 01).bin]:
sectors count: 10890
mode2 sectors: 10890
mode2 (form 1) sectors: 10766
mode2 (form 2) sectors: 124
mode2 (form 2) EDC: yes
specifically, if it says "mode2 (form 2) EDC: yes" in the redumper log, then MPF should treat EDC as Yes in the submission info. Conversely, if it is not detected, the redumper log will say mode2 (form 2) EDC: no
I've attached the redumper log, and the MPF submissioninfo file, for a recent dump I did where EDC should be Yes but MPF says no. Let me know if any other information is needed.
!submissionInfo.txt
SLPM-80582.log
@mnadareski commented on GitHub (Sep 29, 2023):
Oh I see, it changed a little. The current code assumes a line that just has
EDC: yes/noand not with the prefix.