mirror of
https://github.com/SabreTools/MPF.git
synced 2026-02-03 21:29:27 +00:00
[Request] Enhance Volume Label detection and output in !submissioninfo.txt #631
Reference in New Issue
Block a user
Delete Branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @PurpleNekoNova on GitHub (Oct 15, 2023).
Originally assigned to: @mnadareski on GitHub.
At the moment MPF appears to prioritize the ISO9660 volume label to output into !submissioninfo.
My suggestion is to output all present volume labels (ISO, Joliet, HFS, UDF, Rock Ridge, etc)
Example:
[T:VOL]
GAMENAME123 (ISO9660)
GameName123 (Joliet)
GameName12345 (HFS)
GameNameABCD (UDF)
...
@mnadareski commented on GitHub (Oct 18, 2023):
I believe that I would need a
[T:VOL]for every line given that it's not typically a multi-line field, similar to things like alternative titles.@sadikyo commented on GitHub (Oct 18, 2023):
We should discuss as staff just to make sure we want all that before seeing it on every submission. I'm not saying for certain it won't be included, just that it should be discussed.
@PurpleNekoNova commented on GitHub (Oct 18, 2023):
We could do away with the [T:VOL] tag and use custom tags:
...
So we're at least not reusing tags, at it'll look cleaner.
@mnadareski commented on GitHub (Oct 18, 2023):
Pseudo-tags make me sad.
@Deterous commented on GitHub (Jan 11, 2024):
MPF currently gets whatever volume label Windows sees (typically the ISO9660 label as you mentioned, but sometimes UDF). MPF is not privy to the volume type for this label.
MPF directly reading volume labels from disc is likely out of scope, instead will be limited to whatever labels are available in the dumping program's logs.
As far as I can tell, DIC logs provide the ISO9660 and Joliet volume labels, Redumper logs currently have only the ISO9660 label, and I haven't looked into Aaru.
So the best that can be done so far is DIC outputting the Joliet volume label as well as the existing ISO9660 one. Also, if Windows sees a UDF label that differs from ISO9660 label, then MPF could output the ISO9660 label to the submission info. The work for this would mean it should be easy to add other label types if dumping programs support them in the future.