mirror of
https://github.com/SabreTools/MPF.git
synced 2026-02-03 21:29:27 +00:00
[Problem] MPF.Check outputs PS5 disc size wrong as BD-33 instead of BD-66 in !submissionInfo.txt #656
Reference in New Issue
Block a user
Delete Branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @gmipf on GitHub (Nov 28, 2023).
Originally assigned to: @mnadareski on GitHub.
Before You Submit
Version
Build
Describe the issue
A 2-layer PS5 disc is wrongfully described as a BD-33 in !submissionInfo.txt
To Reproduce
Steps to reproduce the behavior:
Dump a 2 layer PS5 disc in redumper, run mpf.check on that dump.
log: ps5_f23_ppsa06275.zip
@mnadareski commented on GitHub (Nov 30, 2023):
The layerbreak information is missing from your logs. I'm gonna get @superg to look at this because it might be an issue from the Redumper side.
@mnadareski commented on GitHub (Nov 30, 2023):
This appears to have been fixed by Redumper build 271. Please try that out and rerun your test. It should function as expected.
@gmipf commented on GitHub (Dec 2, 2023):
Added new log, it is shown as BD-66 now on latest redumper + latest MPF.Check. But now there is a new problem. The disc wasn't detected in the redump db. MPF.Check output:
ps5_f23.zip
PS: WTH even is skeleton in latest redumper? It took an extra while to end the dump.
@superg commented on GitHub (Dec 2, 2023):
Which disc do you expect it to match with?
It's an extra feature where we capture disc structure without any data. Useful for many things, mod can check the structure with IsoBuster, file dates, etc.
@Deterous commented on GitHub (Dec 2, 2023):
Known issue, fixed already:
807b0c5f9e@superg commented on GitHub (Dec 2, 2023):
Ah, so it matches to FIFA, I thought there is still redumper issue where I don't generate proper iso.
@gmipf commented on GitHub (Dec 2, 2023):
@superg Every BD dump since the addition of BD support matched with redumper. No problem there.
@mnadareski commented on GitHub (Dec 2, 2023):
That is a separate issue that has already been fixed. Thank you for confirming.