mirror of
https://github.com/SabreTools/MPF.git
synced 2026-02-09 05:35:27 +00:00
[Request] Read executable date from logs, if available #667
Reference in New Issue
Block a user
Delete Branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @mnadareski on GitHub (Jan 12, 2024).
Originally assigned to: @mnadareski, @Deterous on GitHub.
In a long-standing complaint from a subset of moderators, the current MPF code takes executable dates for PS1 and PS2 directly from the executables themselves, adjusting to UTC to account for international dumpers. Previously, dumpers have used a combination of local datetimes (as seen in whatever timezone they are in) or from the logs provided by the dumping programs.
This request covers trying to read those executable dates from the provided logs as a primary source, falling back on the UTC date if either the date in the logs is invalid or the logs do not contain a date at all. This should help some of the confusion and frustration that the original change to UTC brought.
@Deterous commented on GitHub (Jan 19, 2024):
What systems should this apply to? There are a lot of systems that have exe or build date in redump.
MPF currently does at least PSX/PS2/KP2/GDROM/SEGACD/SATURN
@mnadareski commented on GitHub (Jan 20, 2024):
Preferably all of the ones that look at a physical file for the date. At the very least that's PSX, PS2, and KP2. I believe the others come from internal values.