mirror of
https://github.com/SabreTools/MPF.git
synced 2026-02-08 05:37:45 +00:00
[Problem] MPF includes AA.2 track generated by Redumper when looking for Redump matches #679
Reference in New Issue
Block a user
Delete Branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @PurpleNekoNova on GitHub (Jan 31, 2024).
Originally assigned to: @mnadareski on GitHub.
Version
What version are you using?
Build
What runtime version are you using?
Describe the issue
When dumping a multisession disc with Redumper and a AA.2 track is generated, MPF includes this when looking for db matches on Redump.org
Screenshots
@Deterous commented on GitHub (Jan 31, 2024):
Expected functionality is that only tracks with positive numbers should be checked against redump.org?
i.e. Track 1, 2, 3, ... only?
not: Track 0, A, AA1, B, 2B, whatever, etc?
Currently it works on denylist for 0, 0.2, 00, 00.2, A, AA
Rather than add another line for AA.2, it may be easier to only allow positive integers?
@mnadareski commented on GitHub (Jan 31, 2024):
The
.Xat the end is the session number. There are generally a max of 2 sessions on a disc, so I think it's safe to do so.@Deterous commented on GitHub (Jan 31, 2024):
Current:
0,0.2,00,00.2,A,AAAdd:
AA.2What about
A.2? Is there anything else you can conceive occurring?@mnadareski commented on GitHub (Jan 31, 2024):
Basically every variant can optionally have a
.2suffix. In theory, if there was a disc with more sessions, those would be suffixed with their respective session numbers. Given that.2is rare enough and I haven't personally seen a.3, I think it's safe to just hardcode a new value in the list for now. If there's a reason to make it more extensible in the future, then we can do so.