mirror of
https://github.com/SabreTools/MPF.git
synced 2026-02-03 21:29:27 +00:00
[Bug] CD-ROM Dumping causes string_to_enum failed, Error #696
Reference in New Issue
Block a user
Delete Branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @Con-Rez on GitHub (Mar 15, 2024).
Originally assigned to: @mnadareski on GitHub.
Describe the issue
Cannot use anything other than DiscImageCreator for dumping CD-ROMs using "PLEXTOR DVDR PX-716A USB Device" as labeled in Device Manager on latest CD-Drive Firmware. Reproduced on fresh install. Tested on three discs. Error from log below:
To Reproduce
Steps to reproduce the behavior:
=== 2024-03-14 22:08:44 ========================================================
error: string_to_enum failed, no such value in dictionary (possible values: GENERIC, PLEXTOR, LG_ASU8A, LG_ASU8B, LG_ASU8C, LG_ASU3, LG_ASU2)
Expected behavior
To Dump the CD without immediately cancelling the dump and outputting an error log without further context in the console on what went wrong.
Additional context
@Deterous commented on GitHub (Mar 15, 2024):
This sounds like a Redumper issue: https://github.com/superg/redumper
@Con-Rez commented on GitHub (Mar 15, 2024):
It seems to work only when the Launch Parameter for drive-type is changed to PLEXTOR. Maybe a drop-down should be added to select drive-type beforehand, or further clarification in the error regarding what to do. I'll edit the title and issue accordingly.
@Deterous commented on GitHub (Mar 15, 2024):
Selecting the drive type is not required, redumper automatically detects this. The issue is that redumper does not recognise your drive. What firmware version do you have? What specific model number does the drive label say?
@Con-Rez commented on GitHub (Mar 15, 2024):
The one listed as up-to-date on Redump: http://wiki.redump.org/index.php?title=Optical_Disc_Drive_Compatibility#CD-ROM_.2F_CD-Audio
I thought MPF handled drive detection for the launch options?
Here's a picture of the drive (i'm embarrassed by the blur):
@Deterous commented on GitHub (Mar 15, 2024):
Thank you for the confirmation, just ensure you have firmware version 1.11 in the device manager.
Also ensure you're selecting the correct drive (ensure the drive letter matches your Plextor).
MPF detects the drive letter, but not the model. Redumper is what detects the drive type.
I'm not sure why Redumper doesn't detect it, I think you'll have to raise an issue there https://github.com/superg/redumper/issues
@Con-Rez commented on GitHub (Mar 15, 2024):
It is, the event logs list it as "Device USBSTOR\CdRom&Ven_PLEXTOR&Prod_DVDR___PX-716A&Rev_1.11" I'll mark this as closed then.
@Con-Rez commented on GitHub (Mar 15, 2024):
I've found the issue, and its specific to MPF!
By default drive-type is set to "--drive-type=Generic". It should be set to "--drive-type=GENERIC". Capitalization was the issue!
@Deterous commented on GitHub (Mar 15, 2024):
ef7510804e/MPF.Core/Modules/Redumper/Parameters.cs (L1095)Good find! I will fix that.
Does that mean you have "RedumperUseGenericDriveType" set to true in MPF options?
It should be false by default. Try unticking that option and see if it works for you. You won't want it checked if you're using a Plextor
@Con-Rez commented on GitHub (Mar 15, 2024):
Yea, I had it set to true! I was attempting to use a unsupported Blu-Ray drive a year earlier for PS3 stuff. I thought that option would've been wiped deleting the previous MPF and using a fresh download though. Setting "RedumperUseGenericDriveType" to false fixed my other dump issues as well using the drive. Thanks! I'll mark this as resolved again, this time for real!
@Deterous commented on GitHub (Mar 15, 2024):
If you install new MPF versions by extracting over the top (as we expect you to) then the options are retained via the config.json file, hence why the option was still true