SabreTools/MPF
1
0
Fork 0
mirror of https://github.com/SabreTools/MPF.git synced 2026-02-07 13:52:12 +00:00
Code Issues 392 Packages Projects Releases 20 Wiki Activity

[Request] Add an option for redumper --drive-sector-order #703

New Issue
Closed
opened 2026-01-29 16:20:56 +00:00 by claunia · 2 comments
claunia commented 2026-01-29 16:20:56 +00:00
Owner
Copy Link

Originally created by @GregWeil on GitHub (Apr 13, 2024).

Originally assigned to: @Deterous on GitHub.

My Pioneer drive doesn't support C2 error codes, so I have to specify --drive-sector-order=DATA_SUB on the command line every time. It'd be much more convenient if there was a dropdown for the sector order alongside the existing BE_CDDA option.

Alternatively, a way to specify misc extra params to always get added on to the command line would also be nice.

Originally created by @GregWeil on GitHub (Apr 13, 2024). Originally assigned to: @Deterous on GitHub. My Pioneer drive doesn't support C2 error codes, so I have to specify `--drive-sector-order=DATA_SUB` on the command line every time. It'd be much more convenient if there was a dropdown for the sector order alongside the existing BE_CDDA option. Alternatively, a way to specify misc extra params to always get added on to the command line would also be nice.
claunia added the enhancementhelp wanted labels 2026-01-29 16:20:56 +00:00
claunia commented 2026-01-29 16:20:56 +00:00
Author
Owner
Copy Link

@mnadareski commented on GitHub (Apr 14, 2024):

I'm sorry, but for the primary use of this frontend, having this be a configurable option for most people would make thins more difficult. Having configurable extra params is possible in the future, but it is not currently being looked at. I will mark this as "help wanted" if anyone is willing to do the second option.

@mnadareski commented on GitHub (Apr 14, 2024): I'm sorry, but for the primary use of this frontend, having this be a configurable option for most people would make thins more difficult. Having configurable extra params is possible in the future, but it is not currently being looked at. I will mark this as "help wanted" if anyone is willing to do the second option.
claunia commented 2026-01-29 16:20:56 +00:00
Author
Owner
Copy Link

@Deterous commented on GitHub (Apr 16, 2024):

The current options for BE_CDDA and GENERIC contradicts the reason for not having DATA_SUB as an option. In fact, BE_CDDA and GENERIC options have already caused issues for redump in the past due to users previously ticking them then later using a different drive. I suggest the sector order be hidden behind an advanced options / non-redump mode warning, alongside read method and generic drive type.

Of course, I'll also implement this, not just suggest it.

@Deterous commented on GitHub (Apr 16, 2024): The current options for BE_CDDA and GENERIC contradicts the reason for not having DATA_SUB as an option. In fact, BE_CDDA and GENERIC options have already caused issues for redump in the past due to users previously ticking them then later using a different drive. I suggest the sector order be hidden behind an advanced options / non-redump mode warning, alongside read method and generic drive type. Of course, I'll also implement this, not just suggest it.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
duplicate
enhancement
good first issue
help wanted
invalid
pull-request
Mirrored from GitHub Pull Request
 question
regression
wontfix
No Label enhancement help wanted
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: SabreTools/MPF#703
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?