mirror of
https://github.com/SabreTools/MPF.git
synced 2026-02-11 13:45:26 +00:00
[Problem] PS2 information not pulled (redumper only) #713
Reference in New Issue
Block a user
Delete Branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @fuzz6001 on GitHub (May 27, 2024).
Originally assigned to: @mnadareski on GitHub.
Version
Build
Describe the issue
Region, EXE Date, ISN and Version are not pulled for PS2.
This problem occurs only with redumper and works fine with dic.
To Reproduce
Expected behavior
Pull information.
Additional context
!submissionInfo.txt
redumper .log
@Deterous commented on GitHub (May 27, 2024):
What does the
*** INFOsection of the redumper log say?It may be a problem with only partial information obtained from redumper log:
70114ee59e/MPF.Core/Modules/Redumper/Parameters.cs (L427-L442)The "fallback" method does not run even if the redumper log is missing some info.
@fuzz6001 commented on GitHub (May 27, 2024):
Added .log to the first post.
@mnadareski commented on GitHub (Jun 4, 2024):
Fixed in massive set of changes.
@JohnVeness commented on GitHub (Jul 7, 2024):
Hi. I don't know if it's a partially lingering example of this bug, but I notice that even in 3.2.0, with a PS2 DVD I dump with redumper, MPF.UI (in Windows) correctly puts the region into submissioninfo, but MPF.Check does not (both in Windows and Linux).
SLES-51252.log
!submissionInfo-from-windows-MPFUI.txt
!submissionInfo-from-windows-MPFCheck.txt
!submissionInfo-from-linux-MPFCheck.txt
@Deterous commented on GitHub (Jul 7, 2024):
MPF does it's own region detection, however it relies on the disc being mounted. That's why Check can't get the region, as Check is passive (only reads logs). Regardless you should be double checking your region manually for redump submissions anyway.
@JohnVeness commented on GitHub (Jul 7, 2024):
Ah thanks. I've just tested further and I see that MPF.Check in Windows will detect the region if I add "-p d:" to the command-line while the disc is still in the ODD.
However, MPF.Check in Linux still won't detect the region even if I do the equivalent (i.e. mount the disc and pass the folder name, like "-p /run/media/john/333d3c3734333d32" in this particular disc's case). I can add this as a separate issue if desired.
Any particular reason you don't parse the region info from the redumper log? Is redumper less accurate?
@Deterous commented on GitHub (Jul 7, 2024):
Yes, the region information from redumper log is not considered to be worthwhile keeping.