mirror of
https://github.com/SabreTools/MPF.git
synced 2026-02-03 21:29:27 +00:00
[Problem] The "Overwrite?" window incorrectly identifies a Redumper dump as an Aaru dump #725
Reference in New Issue
Block a user
Delete Branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @TheRogueArchivist on GitHub (Jul 12, 2024).
Originally assigned to: @mnadareski on GitHub.
Version
2983266Build
Describe the issue
When trying to create an image in a directory that contains a finished Redumper image, MPF misidentifies it as an Aaru image.
To Reproduce
Expected behavior
I would expect MPF to identify the completed dump properly as a Redumper image.
Screenshots
@Deterous commented on GitHub (Jul 12, 2024):
As you're trying to dump with DIC, it tries to look for a complete DIC dump (i.e. at least a .img file and the logs zip).
It doesn't find it, so it goes through these methods:
2983266e8a/MPF.Frontend/DumpEnvironment.cs (L151)Aaru is the first one attempted, which only looks for the logs zip, and matches immediately.
I would suggest a simple solution would be to just change the order and look for DIC first, then Redumper, then Aaru.
@TheRogueArchivist commented on GitHub (Jul 12, 2024):
I'd personally say a more identifying check would be good, possibly in addition to reordering. For example, DIC should still be the only one producing an IMG while Redumper is definitely the only one producing a scram/scrap file.
@mnadareski commented on GitHub (Oct 10, 2024):
Does this still happen on latest? The entire system of identifying files has been overhauled since this was opened and the newest stable includes those changes.
@Deterous commented on GitHub (Oct 11, 2024):
Was it only recently that you started checking inside the log zip file? In which case it should be fixed/better.
I still think as a precaution the order of checking in this function should change:
83a189a5d3/MPF.Frontend/DumpEnvironment.cs (L154)Currently: Aaru -> DIC -> redumper
Better: Redumper -> DIC -> Aaru
Reason being that Aaru is the least commonly used and has fewer specific output files. Although with the newer changes, I guess false positives are almost surely not possible?
@mnadareski commented on GitHub (Oct 11, 2024):
The check inside of zips was part of the output file handling overhaul, yes. That's why I just want to have someone check. Then the order of the programs being checked won't matter and alphabetical would be fine.