[Problem] MPF.CLI checks for device path or device path instead of device path or file path #733

New Issue

Open

opened 2026-01-29 16:21:26 +00:00 by claunia · 0 comments

claunia commented 2026-01-29 16:21:26 +00:00

Owner

Copy Link

Originally created by @Daja177 on GitHub (Aug 16, 2024).

Originally assigned to: @mnadareski on GitHub.

Version
What version are you using?

• Stable release (v3.2.1)
• WIP release (version here)

Build
What runtime version are you using?

• .NET 6.0 running on (Operating System)
• .NET 8.0 running on Linux

Describe the issue
The source code implies that MPF.CLI should require both device path and file path to be specified, but due to a mistake in the check, it checks for device path or device path instead of device path or file path.
11b8dd44bb/MPF.CLI/Program.cs (L104C79-L104C89)

To Reproduce
Steps to reproduce the behavior:

1. Run MPF.CLI with media type, system type and device path being provided but not file path
2. Starts dumping (with Redumper at least)

Expected behavior
Getting error "Both a device path and file path need to be supplied, exiting..."

Originally created by @Daja177 on GitHub (Aug 16, 2024). Originally assigned to: @mnadareski on GitHub. **Version** What version are you using? - [x] Stable release (v3.2.1) - [ ] WIP release (version here) **Build** What runtime version are you using? - [ ] .NET 6.0 running on (Operating System) - [x] .NET 8.0 running on Linux **Describe the issue** The source code implies that MPF.CLI should require both device path *and* file path to be specified, but due to a mistake in the check, it checks for device path or device path instead of device path or file path. https://github.com/SabreTools/MPF/blob/11b8dd44bbb25067ba59fcd0855ba64bca74be3c/MPF.CLI/Program.cs#L104C79-L104C89 **To Reproduce** Steps to reproduce the behavior: 1. Run MPF.CLI with media type, system type and device path being provided but not file path 2. Starts dumping (with Redumper at least) **Expected behavior** Getting error "Both a device path and file path need to be supplied, exiting..."

claunia added the bug label 2026-01-29 16:21:26 +00:00

claunia referenced this issue 2026-01-29 16:25:40 +00:00

[PR #733] [MERGED] Fix XGD3 SS ranges #1140

Sign in to join this conversation.

No Branch/Tag Specified

Branches Tags

master

rolling

3.6.0

3.5.0

3.4.2

3.4.1

3.4.0

3.3.3

3.3.2

3.3.1

3.3.0

3.2.4

3.2.3

3.2.2

3.2.1

3.2.0

3.1.9

3.1.8

3.1.7

3.1.6

3.1.5

3.1.4

3.1.3

3.1.2

check-rolling

ui-rolling

3.1.1

3.1.0

3.0.3

3.0.2

3.0.1

3.0.0

2.7.5

2.7.4

2.7.3

2.7.2

2.7.1

2.7.0

2.6.6

2.6.5

2.6.4

2.6.3

2.6.2

2.6.1

2.6

2.5

2.4

2.3

2.2

2.1

2.0

1.18

1.17.1

1.17

1.16.1

1.16

1.15

1.14

1.13

1.12.2

1.12.1

1.12

1.11

1.10

1.07

1.06

1.05.1

1.05

1.04b

1.04a

1.04

1.03

1.02b

1.02

1.01d

1.01c

1.01b

Labels

Clear labels

bug

duplicate

enhancement

good first issue

help wanted

invalid

pull-request

Mirrored from GitHub Pull Request

question

regression

wontfix

No Label bug

Milestone

No items

No Milestone

Projects

Clear projects

No project

Assignees

Clear assignees

claunia

No Assignees

1 Participants

Notifications

Subscribe

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: SabreTools/MPF#733