[Problem] MPF.CLI is unable to handle spaces in drive path #735

Closed
opened 2026-01-29 16:21:26 +00:00 by claunia · 0 comments
Owner

Originally created by @Daja177 on GitHub (Aug 16, 2024).

Originally assigned to: @mnadareski on GitHub.

Version
WIP release (3.2.1-426717102d69a09f65faa792a7f36560520ea6a5)

Build
.NET 8.0 running on Linux x64

Describe the issue
MPF.CLI sends the drive path to Redumper without quotation marks, resulting in Redumper (and possibly other dumping programs) being unable to dump from a path that contains a space. Giving MPF.CLI a path like /run/media/daniel/Läsning 6-7 results in Redumper attempting to dump from /run/media/daniel/Läsning.

Output:

$ MPF.CLI cdrom pc -d /run/media/daniel/Läsning\ 6-7 -f "Läsning 6-7" 
Credentials entered, will attempt Redump login...
Credentials accepted! Logged into Redump...
Redump username and password accepted!
Invoking Redumper using 'cd --verbose --drive=/run/media/daniel/Läsning 6-7 --speed=24 --retries=20 --image-name="Läsning 6-7"'
Executing Redumper... please wait!
error: unable to open drive (/run/media/daniel/Läsning, SYSTEM: No such file or directory)
Redumper has finished!
CD-ROM ready to dump
Gathering submission information... please wait!
Error! Please check output directory as dump may be incomplete!
There were files missing from the output:
Läsning 6-7.cue
Läsning 6-7.scram
Läsning 6-7.fulltoc

It also happens when I type -d "/run/media/daniel/Läsning 6-7".

To Reproduce
Steps to reproduce the behavior:

  1. Run MPF.CLI and give it a path that contains a space
  2. See error

Expected behavior
Redumper should attempt to dump from the complete path rather than just the part up until the space in the path.

Additional context
This issue isn't particularly important as there are very few cases where the drive path would contain a space. I only discovered this issue because I mistakenly thought giving MPF.CLI the mount path would work.

Originally created by @Daja177 on GitHub (Aug 16, 2024). Originally assigned to: @mnadareski on GitHub. **Version** WIP release (3.2.1-426717102d69a09f65faa792a7f36560520ea6a5) **Build** .NET 8.0 running on Linux x64 **Describe the issue** MPF.CLI sends the drive path to Redumper without quotation marks, resulting in Redumper (and possibly other dumping programs) being unable to dump from a path that contains a space. Giving MPF.CLI a path like `/run/media/daniel/Läsning 6-7` results in Redumper attempting to dump from `/run/media/daniel/Läsning`. Output: ``` $ MPF.CLI cdrom pc -d /run/media/daniel/Läsning\ 6-7 -f "Läsning 6-7" Credentials entered, will attempt Redump login... Credentials accepted! Logged into Redump... Redump username and password accepted! Invoking Redumper using 'cd --verbose --drive=/run/media/daniel/Läsning 6-7 --speed=24 --retries=20 --image-name="Läsning 6-7"' Executing Redumper... please wait! error: unable to open drive (/run/media/daniel/Läsning, SYSTEM: No such file or directory) Redumper has finished! CD-ROM ready to dump Gathering submission information... please wait! Error! Please check output directory as dump may be incomplete! There were files missing from the output: Läsning 6-7.cue Läsning 6-7.scram Läsning 6-7.fulltoc ``` It also happens when I type `-d "/run/media/daniel/Läsning 6-7"`. **To Reproduce** Steps to reproduce the behavior: 1. Run MPF.CLI and give it a path that contains a space 2. See error **Expected behavior** Redumper should attempt to dump from the complete path rather than just the part up until the space in the path. **Additional context** This issue isn't particularly important as there are very few cases where the drive path would contain a space. I only discovered this issue because I mistakenly thought giving MPF.CLI the mount path would work.
claunia added the bug label 2026-01-29 16:21:26 +00:00
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: SabreTools/MPF#735