[Problem] MPF does not zip [dump].0.manufacturer file #745

New Issue

Closed

opened 2026-01-29 16:21:36 +00:00 by claunia · 0 comments

claunia commented 2026-01-29 16:21:36 +00:00

Owner

Copy Link

Originally created by @TurnedToast on GitHub (Sep 7, 2024).

Originally assigned to: @mnadareski on GitHub.

Occurs in current stable and today's WIP, .NET 8.0 running on Windows 11

Describe the issue
When dumping [PS2] Sakura Wars: So Long My Love, which has two dual-layer DVDs, redumper outputs two .manufacturer files:

1. [title].0.manufacturer
2. [title].1.manufacturer

After finishing the dump and filling info, the compression of the log files does not include the "0" manufacturer file and leaves the file chilling outside the zip

To Reproduce
Dump a dual layer PS2 game. I don't have any non-PS2 dual layer DVDs to test, but based on the code this could be an issue for any DVD media.

This ocureed for the two Sakura Wars discs and a Yakuza 2 disc I tested

Expected behavior
all .manufacturer files are zipped

Additional context
in MPF.Processors\Redumper.cs under case MediaType.DVD, the .physical file list accounts for 0, 1, and 2 .physical, but for .manufacturer names it only returns 1 and 2. Adding another entry for $"{baseFilename}.0.manufacturer" fixes the issue for my disks

Originally created by @TurnedToast on GitHub (Sep 7, 2024). Originally assigned to: @mnadareski on GitHub. Occurs in current stable and today's WIP, .NET 8.0 running on Windows 11 **Describe the issue** When dumping [PS2] Sakura Wars: So Long My Love, which has two dual-layer DVDs, redumper outputs two .manufacturer files: 1. [title].0.manufacturer 2. [title].1.manufacturer After finishing the dump and filling info, the compression of the log files does not include the "0" manufacturer file and leaves the file chilling outside the zip **To Reproduce** Dump a dual layer PS2 game. I don't have any non-PS2 dual layer DVDs to test, but based on the code this could be an issue for any DVD media. This ocureed for the two Sakura Wars discs and a Yakuza 2 disc I tested **Expected behavior** all .manufacturer files are zipped **Additional context** in MPF.Processors\Redumper.cs under case MediaType.DVD, the .physical file list accounts for 0, 1, and 2 .physical, but for .manufacturer names it only returns 1 and 2. Adding another entry for $"{baseFilename}.0.manufacturer" fixes the issue for my disks

claunia added the bug label 2026-01-29 16:21:36 +00:00

claunia closed this issue 2026-01-29 16:21:36 +00:00

Sign in to join this conversation.

No Branch/Tag Specified

Branches Tags

master

rolling

3.6.0

3.5.0

3.4.2

3.4.1

3.4.0

3.3.3

3.3.2

3.3.1

3.3.0

3.2.4

3.2.3

3.2.2

3.2.1

3.2.0

3.1.9

3.1.8

3.1.7

3.1.6

3.1.5

3.1.4

3.1.3

3.1.2

check-rolling

ui-rolling

3.1.1

3.1.0

3.0.3

3.0.2

3.0.1

3.0.0

2.7.5

2.7.4

2.7.3

2.7.2

2.7.1

2.7.0

2.6.6

2.6.5

2.6.4

2.6.3

2.6.2

2.6.1

2.6

2.5

2.4

2.3

2.2

2.1

2.0

1.18

1.17.1

1.17

1.16.1

1.16

1.15

1.14

1.13

1.12.2

1.12.1

1.12

1.11

1.10

1.07

1.06

1.05.1

1.05

1.04b

1.04a

1.04

1.03

1.02b

1.02

1.01d

1.01c

1.01b

Labels

Clear labels

bug

duplicate

enhancement

good first issue

help wanted

invalid

pull-request

Mirrored from GitHub Pull Request

question

regression

wontfix

No Label bug

Milestone

No items

No Milestone

Projects

Clear projects

No project

Assignees

Clear assignees

claunia

No Assignees

1 Participants

Notifications

Subscribe

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: SabreTools/MPF#745