mirror of
https://github.com/SabreTools/MPF.git
synced 2026-02-10 21:30:29 +00:00
[Discussion] Skeleton by default for non-bluray #759
Reference in New Issue
Block a user
Delete Branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @Deterous on GitHub (Nov 7, 2024).
Originally assigned to: @mnadareski on GitHub.
Now that redumper does not create skeletons by default, MPF should probably append skeleton to the redumper command. Not creating skeletons by default for blu-ray discs will avoid long dumping times and bad skeletons with UDF. Additionally, DVD-Video is also currently known to create bad skeletons. There may be more system-media combos that we want to avoid skeletons for?
@mnadareski commented on GitHub (Nov 7, 2024):
Personally, I don't want to include by default or include a configuration option to include skeletons until I can get confirmation on why they were removed from default dumping to begin with. If I add either of those, I risk using a feature that might get deprecated or removed.
@Deterous commented on GitHub (Nov 8, 2024):
From the horses mouth:
That is to say, its intended use is as I'm suggesting (append the command), and the reasons I suggest not to run skeleton for DVD-Video and all bluray is why it was removed by default.
Things that will likely change in the future is the compression method used for skeleton files (replacing LZMA, or even removing compression altogether). The feature is unlikely to be deprecated or removed.
@mnadareski commented on GitHub (Nov 18, 2024):
Given the information above I believe that adding
skeletonto CDs only is safe. I feel it is reasonable to stay that way by default until Redumper adds it back.@mnadareski commented on GitHub (Nov 18, 2024):
Implemented in
466d8f58b0@Deterous commented on GitHub (Nov 19, 2024):
I'm not sure it will ever be added back by default.