[Discussion] Skeleton by default for non-bluray #759

Closed
opened 2026-01-29 16:21:49 +00:00 by claunia · 5 comments
Owner

Originally created by @Deterous on GitHub (Nov 7, 2024).

Originally assigned to: @mnadareski on GitHub.

Now that redumper does not create skeletons by default, MPF should probably append skeleton to the redumper command. Not creating skeletons by default for blu-ray discs will avoid long dumping times and bad skeletons with UDF. Additionally, DVD-Video is also currently known to create bad skeletons. There may be more system-media combos that we want to avoid skeletons for?

Originally created by @Deterous on GitHub (Nov 7, 2024). Originally assigned to: @mnadareski on GitHub. Now that redumper does not create skeletons by default, MPF should probably append skeleton to the redumper command. Not creating skeletons by default for blu-ray discs will avoid long dumping times and bad skeletons with UDF. Additionally, DVD-Video is also currently known to create bad skeletons. There may be more system-media combos that we want to avoid skeletons for?
claunia added the enhancement label 2026-01-29 16:21:49 +00:00
Author
Owner

@mnadareski commented on GitHub (Nov 7, 2024):

Personally, I don't want to include by default or include a configuration option to include skeletons until I can get confirmation on why they were removed from default dumping to begin with. If I add either of those, I risk using a feature that might get deprecated or removed.

@mnadareski commented on GitHub (Nov 7, 2024): Personally, I don't want to include by default _or_ include a configuration option to include skeletons until I can get confirmation on why they were removed from default dumping to begin with. If I add either of those, I risk using a feature that might get deprecated or removed.
Author
Owner

@Deterous commented on GitHub (Nov 8, 2024):

From the horses mouth:

it often errors out and people think dump failed with error
it's so slow for dvd+
it's easy to do that externally with redumper cd skeleton ...

That is to say, its intended use is as I'm suggesting (append the command), and the reasons I suggest not to run skeleton for DVD-Video and all bluray is why it was removed by default.

Things that will likely change in the future is the compression method used for skeleton files (replacing LZMA, or even removing compression altogether). The feature is unlikely to be deprecated or removed.

@Deterous commented on GitHub (Nov 8, 2024): From the horses mouth: > it often errors out and people think dump failed with error it's so slow for dvd+ it's easy to do that externally with redumper cd skeleton ... That is to say, its intended use is as I'm suggesting (append the command), and the reasons I suggest not to run skeleton for DVD-Video and all bluray is why it was removed by default. Things that will likely change in the future is the compression method used for skeleton files (replacing LZMA, or even removing compression altogether). The feature is unlikely to be deprecated or removed.
Author
Owner

@mnadareski commented on GitHub (Nov 18, 2024):

Given the information above I believe that adding skeleton to CDs only is safe. I feel it is reasonable to stay that way by default until Redumper adds it back.

@mnadareski commented on GitHub (Nov 18, 2024): Given the information above I believe that adding `skeleton` to CDs only is safe. I feel it is reasonable to stay that way by default until Redumper adds it back.
Author
Owner

@mnadareski commented on GitHub (Nov 18, 2024):

Implemented in 466d8f58b0

@mnadareski commented on GitHub (Nov 18, 2024): Implemented in https://github.com/SabreTools/MPF/commit/466d8f58b0f095fabb49e1b74c88eaed04a2ca0f
Author
Owner

@Deterous commented on GitHub (Nov 19, 2024):

until Redumper adds it back.

I'm not sure it will ever be added back by default.

@Deterous commented on GitHub (Nov 19, 2024): > until Redumper adds it back. I'm not sure it will ever be added back by default.
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: SabreTools/MPF#759