[Problem] DIC's basename_YYYYMMDDTHHMMSS.txt isn't zipped #760

New Issue

claunia · 2026-01-29T16:21:51Z

claunia commented

2026-01-29 16:21:51 +00:00

Originally created by @Deterous on GitHub (Nov 25, 2024).

Originally assigned to: @mnadareski on GitHub.

Had a look and can't decode your new output files framework to find what's going wrong, but dump_20241001T225411.txt isn't zipped despite it clearly matching the regex below and is flagged as Zippable.

new RegexOutputFile(Regex.Escape(baseFilename) + @"_(\d{8})T\d{6}\.txt", OutputFileFlags.Required
                            | OutputFileFlags.Artifact
                            | OutputFileFlags.Zippable,
                            "cmd"),

Somewhere in e72336a835/MPF.Processors/BaseProcessor.cs (L521) it must be not getting the correct filename. Maybe you can spot what's wrong without having to debug this.

Originally created by @Deterous on GitHub (Nov 25, 2024). Originally assigned to: @mnadareski on GitHub. Had a look and can't decode your new output files framework to find what's going wrong, but `dump_20241001T225411.txt` isn't zipped despite it clearly matching the regex below and is flagged as Zippable. ```cs new RegexOutputFile(Regex.Escape(baseFilename) + @"_(\d{8})T\d{6}\.txt", OutputFileFlags.Required | OutputFileFlags.Artifact | OutputFileFlags.Zippable, "cmd"), ``` Somewhere in https://github.com/SabreTools/MPF/blob/e72336a835c61df8636d15b0f4d768ec2c567446/MPF.Processors/BaseProcessor.cs#L521 it must be not getting the correct filename. Maybe you can spot what's wrong without having to debug this.

claunia added the bug label 2026-01-29 16:21:51 +00:00

claunia closed this issue

2026-01-29 16:21:51 +00:00

claunia commented

2026-01-29 16:21:52 +00:00

@Deterous commented on GitHub (Nov 25, 2024):

The issue seems to be that RegexOutputFile isn't returning valid filenames, but instead the regex itself.

@Deterous commented on GitHub (Nov 25, 2024): The issue seems to be that RegexOutputFile isn't returning valid filenames, but instead the regex itself.

claunia commented

2026-01-29 16:21:52 +00:00

@Deterous commented on GitHub (Nov 25, 2024):

This also affects XBC log files, which has occurred in the past (previously unconfirmed whether bug or user error)

@Deterous commented on GitHub (Nov 25, 2024): This also affects XBC log files, which has occurred in the past (previously unconfirmed whether bug or user error)

claunia commented

2026-01-29 16:21:52 +00:00

@mnadareski commented on GitHub (Nov 28, 2024):

Implementation note: Do not blindly return lists, take output type into account. All currently treated as standard.

@mnadareski commented on GitHub (Nov 28, 2024): Implementation note: Do not blindly return lists, take output type into account. All currently treated as standard.

claunia commented

2026-01-29 16:21:52 +00:00

@mnadareski commented on GitHub (Dec 3, 2024):

This should be fixed as of 8eff11f0ae. Unit tests indicate that the proper file will be included in the zippable file paths.

@mnadareski commented on GitHub (Dec 3, 2024): This should be fixed as of https://github.com/SabreTools/MPF/commit/8eff11f0aeb3fb0fa0f6031791afaeaa06b360f6. Unit tests indicate that the proper file will be included in the zippable file paths.

claunia commented

2026-01-29 16:21:52 +00:00

@mnadareski commented on GitHub (Dec 8, 2024):

Confirmed to have been fixed in a real-world test.

@mnadareski commented on GitHub (Dec 8, 2024): Confirmed to have been fixed in a real-world test.

claunia referenced this issue

2026-01-29 16:25:42 +00:00

[PR #760] [MERGED] Fix PIC parser #1148

claunia referenced this issue

2026-01-29 16:25:43 +00:00

[PR #760] Fix PIC parser #1150

Sign in to join this conversation.