mirror of
https://github.com/SabreTools/MPF.git
synced 2026-02-04 05:35:52 +00:00
[Problem] MPF incorrectly looks for SS.bin/.security for XboxOne/XboxSX #764
Reference in New Issue
Block a user
Delete Branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @Deterous on GitHub (Dec 1, 2024).
Originally assigned to: @mnadareski on GitHub.
Currently, Processors/DIC and Processors/Redumper look for _SS.bin and .security respectively, based on
system.IsXGD()This works for Xbox/Xbox360, but incorrectly flags XboxOne and XboxSX as dumps that need _SS.bin/.security, so any dumps with them will fail.
Either RedumpLib needs an update to remove XboxOne/XboxSX from the IsXGD() function, or a more precise check is needed in MPF.Processors
@mnadareski commented on GitHub (Dec 3, 2024):
For Redumper, the code indicates that it only looks for
.securityfor DVD. I was under the impression that all XGD4 discs are Blu-ray, so this should be a non-issue. If you can demonstrate it looking for the file on an XGD4 disc, I will investigate further.For DIC, the checks for Blu-ray have been split out and
_SS.binhas been removed from that set. Thank you for the catch there. The fix went in as ofee4e77b208@Deterous commented on GitHub (Dec 4, 2024):
As long as XboxOne / XboxSX never gets a DVD media added.
Also a todo before this is closed: figure out a way to check whether SS is necessary at all, some Xbox DVDs don't need SS.
@Deterous commented on GitHub (Dec 7, 2024):
if (Xbox || Xbox360) && (DVD) && (DMI.Any(x => x != 0))
Then required .security
For redumper, if .dmi doesn't exist, you'll need to skip the first 4 bytes of the .manufacturer then check if any of the rest are non-zero
@mnadareski commented on GitHub (Dec 8, 2024):
Further enhancement has been split into https://github.com/SabreTools/MPF/issues/774