mirror of
https://github.com/SabreTools/MPF.git
synced 2026-02-04 05:35:52 +00:00
[Request] Remove Packer info from submission info #774
Reference in New Issue
Block a user
Delete Branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @Deterous on GitHub (Dec 10, 2024).
Originally assigned to: @mnadareski on GitHub.
Change options.ScanPackersForProtection to only output packer info to the protection info output text file. Packer info does not belong in submissionInfo.txt as it is not stored in redump.
@mnadareski commented on GitHub (Dec 10, 2024):
This has been band-aid fixed by hard-coding exclusion lists for packers into the current filtering.
@TonyLizard commented on GitHub (Dec 10, 2024):
Please also add the EA Online Registration to the list of elements that should not be showed in submissionInfo.txt file.
@mnadareski commented on GitHub (Dec 10, 2024):
EA CD-key will be filtered out alongside packers and game engines now. I will leave this issue open for a couple of days in case others are found.
@Deterous commented on GitHub (Dec 11, 2024):
It may be cleaner to have a list of prefixes to exclude stored somewhere, and loop through all of them in the filtering code to exclude them with
FindAll(p => !p.StartsWith(x). This would make maintaining the list easier (every time BOS adds new detections).Of course the existing, more advanced filtering to remove duplicates can remain.
@mnadareski commented on GitHub (Dec 11, 2024):
53c6e47fa8@mnadareski commented on GitHub (Dec 12, 2024):
All cases that needed to be covered seem to be for now.