mirror of
https://github.com/SabreTools/MPF.git
synced 2026-02-04 05:35:52 +00:00
[Problem] Manually changing parameters isn't reflected in !submissionInfo.txt #790
Reference in New Issue
Block a user
Delete Branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @Ragowit on GitHub (Jan 5, 2025).
Originally assigned to: @mnadareski on GitHub.
Version
Build
Describe the issue
I changed some parameters manually, yet in the "Dumping Info" part of !submissionInfo.txt I found the default values of "Parameters: bd --verbose --drive=D:\ --speed=8 --retries=20 --image-path=ISO\PS3 --image-name=PS3VOLUME"
To Reproduce
Expected behavior
Same as in the parameter textbox in MPF
@Deterous commented on GitHub (Jan 5, 2025):
I tested this and it works as expected for me.
Can you check your redumper log to see if the custom parameters were actually run? The submission info should match the redumper log.
If you uncheck the custom parameters box, you should either re-check it to apply the parameters, or if you don't and just press dump, then press "Yes" when asked to apply the custom parameters.
@Ragowit commented on GitHub (Jan 5, 2025):
Okay, something is odd, or I just don't understand English fully.
"It looks like you have custom parameters that have not been saved. Would you like to apply those changes before starting to dump?"
In my mind, pressing "Yes" will apply my changes to custom parameters. However, now that I test, pressing "No" does that.
@Ragowit commented on GitHub (Jan 5, 2025):
Just made a new dump, everything checks out correct in "!submissionInfo.txt" if I press "No" in that dialog.
Funny thing is that "image-path" parameter is saved whatever I press Yes or No.
EDIT: For more information, all I do for my custom parameters is that I remove the speed parameter.
Parameters: bd --verbose --drive=D:\ --retries=20 --image-path=ISO\PS3 --image-name=PS3VOLUMEEDIT 2: And I do this because I found out redumper works better with no speed assigned, superg wrote the issue though. https://github.com/superg/redumper/issues/97
@Deterous commented on GitHub (Jan 5, 2025):
The intention is that "Yes" will use your custom parameter, and "No" will use whatever was there before you unchecked the box. If you remove the speed
The issue here is seemingly that pressing "No" still uses the custom parameters, it should not.
The submissionInfo.txt pulls from the redumper log itself, which is whatever was actually run, so it should always be correct.
Interesting about the speed parameter not being in use. I guess MPF should support not providing a value at all (I think DIC requires a value, though). For now, you'll have to keep using custom parameters annoyingly.
@Ragowit commented on GitHub (Jan 5, 2025):
And that "Yes" should use the custom parameter, as it doesn't do right now. Both buttons does the opposite of what it should do.
@Ragowit commented on GitHub (Jan 5, 2025):
That's fine with me, now that I know about it. Thanks for checking it out!
@Deterous commented on GitHub (Jan 5, 2025):
It seems I was wrong, I'm not sure what the fix is. But anyway, the easiest workaround will be to just press No
@Ragowit commented on GitHub (Jan 5, 2025):
Just to give you as much information as possible, this is the exact way I dump stuff.
https://github.com/user-attachments/assets/44df55be-df78-4c41-b256-af2cb718afd5
@Deterous commented on GitHub (Jan 6, 2025):
Not a fix to the problem, but if you're renaming all your files to output into folders by their system name, you can set the default output folder to ISO/%SYS% which will become ISO/PS3/ when dumping a PS3 disc.
@Ragowit commented on GitHub (Jan 6, 2025):
@Deterous That didn't work, see image:
It became
ISO\%SYS%\MINININJAS\MINININJAS.isoWhile I want
ISO\%SYS%\MINININJAS.isoBack on topic, just to keep information in one place, Sabre said that the real issue is probably because that the wrong dialog opens up for me. It should be one with three buttons (Yes/No/Cancel).
@Ragowit commented on GitHub (Apr 18, 2025):
This isn't fixed in the latest WIP. See my comment in the commit:
4557017fc5 (diff-55ecf7cbfeb120021a64d82814f2be48df5324190a23a997bbfdd0883b7307bdR2176)@Deterous commented on GitHub (Apr 18, 2025):
#837 PR adds a "0" option for drive speed, which in DIC means max speed. It will remove the speed flag for redumper.
@Ragowit commented on GitHub (Apr 18, 2025):
That would solve my problem with why I'm using custom parameters in the first place. Thanks.
However, the issue still persists for whoever wants change the parameters.
@Deterous commented on GitHub (Apr 18, 2025):
Pressing "Yes" will apply the custom parameters (same as re-ticking the checkbox).
MPF prevents you from running flags that are not valid. The issue you had was that MPF thought speed was a required parameter.