mirror of
https://github.com/SabreTools/MPF.git
synced 2026-02-03 21:29:27 +00:00
[Problem] Additional Check functionality UI improvement request #802
Reference in New Issue
Block a user
Delete Branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @FoxhackDN on GitHub (Feb 3, 2025).
Originally assigned to: @mnadareski on GitHub.
Version
What version are you using?
Build
What runtime version are you using?
Describe the issue
Check functionality on MPF UI needs some additional error messages (better indication of what is missing.)
I dumped an audio CD as IBM PC by accident; so I figured, I'll use check to generate a new submissioninfo file, but I kept getting this error:
After a bit of discussion, it turned out that the program needed to have all the files that MPF zips up present in the folder so it can do its thing, but it doesn't actually say that in those specific words. I suggest changing the text to read "Make sure all required dump files are in the same folder" or something similar.
Additionally, since it overwrites any submissioninfo files that may be in the folder, it should warn the user before it begins doing anything, after selecting a file to process (a suggestion, of course.)
To Reproduce
No steps needed.
Expected behavior
See above
Screenshots
None needed
@mnadareski commented on GitHub (Apr 30, 2025):
Note for possible fix: This wires into the existing post-dump code, so either a flag needs to be added to say that the check is for Check or the wording needs to be improved for both cases at the same time.
@Deterous commented on GitHub (May 5, 2025):
MPF FoundAllFiles checks the log zip, however it doesn't work when the redumper .log file is in the zip
Additionally, it does not extract the files and it overwrites the zip, resulting in the zipped files being deleted when post-processing.
@mnadareski commented on GitHub (May 5, 2025):
After discussing this elsewhere, it seems like this falls into a use-case that I never really expected: reprocessing MPF-processed dumps. Check functionality was originally intended to be used on as-is outputs from the various dumping programs. I'll open a new request for that part of this issue, since that will require more work.
This item will be left open to track the wording used in the library when files are missing.
@mnadareski commented on GitHub (May 25, 2025):
With the addition of the warnings in
c5649ecdbb, I'm going to mark this as closed. The other item will remain open until reparsing is either implemented or ruled out.