SabreTools/MPF
1
0
Fork 0
mirror of https://github.com/SabreTools/MPF.git synced 2026-02-03 21:29:27 +00:00
Code Issues 392 Packages Projects Releases 20 Wiki Activity

[Problem] Audio CD: Perfect Audio Offset of +0 incorrectly reported for all instances of Perfect Audio Offset #809

New Issue
Closed
opened 2026-01-29 16:22:35 +00:00 by claunia · 0 comments
claunia commented 2026-01-29 16:22:35 +00:00
Owner
Copy Link

Originally created by @mictlantecuhtle on GitHub (Feb 24, 2025).

Originally assigned to: @mnadareski on GitHub.

Version
What version are you using?

Build
What runtime version are you using?

  • .NET 9.0

Describe the issue
Wherever the phrase "Perfect Audio Offset applied" appears in redumper logs, MPF incorrectly adds a line in !submissionInfo.txt to say <b>Ring Perfect Audio Offset</b>: +0

This line should only be added when BOTH "Perfect Audio Offset applied" AND "disc write offset: +0" appear in the logs.

From examination of various sets of dump logs, this behaviour occurs with both positive and negative offsets.

To Reproduce
Steps to reproduce the behavior:

  1. Dump an Audio CD with either a positive or negative offset.
  2. Check the redumper log to verify that e.g. ""Perfect Audio Offset applied" and "disc write offset: -12" appear
  3. Check the !submissionInfo.txt file to verify that the line <b>Ring Perfect Audio Offset</b>: +0 appears

Expected behavior
The line <b>Ring Perfect Audio Offset</b>: +0 should only be added when BOTH "Perfect Audio Offset applied" AND "disc write offset: +0" appear in the logs.

122041_Foil1332 (+37 offset).zip

121855_Maddog (-12 offset).zip

Originally created by @mictlantecuhtle on GitHub (Feb 24, 2025). Originally assigned to: @mnadareski on GitHub. **Version** What version are you using? - [X] Stable release ([version here](http://redump.org/disc/69435/)) **Build** What runtime version are you using? - [X] .NET 9.0 **Describe the issue** Wherever the phrase "Perfect Audio Offset applied" appears in redumper logs, MPF incorrectly adds a line in !submissionInfo.txt to say `<b>Ring Perfect Audio Offset</b>: +0` This line should only be added when BOTH "Perfect Audio Offset applied" AND "disc write offset: +0" appear in the logs. From examination of various sets of dump logs, this behaviour occurs with both positive and negative offsets. **To Reproduce** Steps to reproduce the behavior: 1. Dump an Audio CD with either a positive or negative offset. 2. Check the redumper log to verify that e.g. ""Perfect Audio Offset applied" and "disc write offset: -12" appear 3. Check the !submissionInfo.txt file to verify that the line `<b>Ring Perfect Audio Offset</b>: +0` appears **Expected behavior** The line `<b>Ring Perfect Audio Offset</b>: +0` should only be added when BOTH "Perfect Audio Offset applied" AND "disc write offset: +0" appear in the logs. [122041_Foil1332 (+37 offset).zip](https://github.com/user-attachments/files/18940149/122041_Foil1332.%2B37.offset.zip) [121855_Maddog (-12 offset).zip](https://github.com/user-attachments/files/18940171/121855_Maddog.-12.offset.zip)
claunia added the bug label 2026-01-29 16:22:35 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
duplicate
enhancement
good first issue
help wanted
invalid
pull-request
Mirrored from GitHub Pull Request
 question
regression
wontfix
No Label bug
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: SabreTools/MPF#809
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?