[Problem] Incorrectly placed quotes in redumper arguments #817

New Issue

claunia · 2026-01-29T16:22:45Z

claunia commented

2026-01-29 16:22:45 +00:00

Originally created by @FoxhackDN on GitHub (Mar 7, 2025).

Originally assigned to: @mnadareski on GitHub.

Version

Stable release 3.3.0
WIP release (version here)

Build
What runtime version are you using?

.NET 9.0 running on Windows 11 Pro

Describe the issue
Incorrectly placed quotes are appearing in the dumping log and command line when using Redumper to dump discs. An example in the command line can be seen here:

redumper v2024.11.03 build_438 [Nov  3 2024, 00:08:55]

arguments: dvd --verbose --debug --drive=D:\ --speed=72 --retries=100 "--image-path=ISO\[DVD] Playmobil Pirate Island [1D]" "--image-name=Playmobil The Secret of Pirate I"

drive path: D:\
drive: HL-DT-ST - DVDRAM GE20LU10 (revision level: FE06, vendor specific: ..0010220822916E2055)
drive configuration: GENERIC (read offset: +667, C2 shift: 0, pre-gap start: +0, read method: BE, sector order: DATA_C2_SUB)
drive read speed: 34184 KB

current profile: DVD-ROM

image path: "ISO\[DVD] Playmobil Pirate Island [1D]"
image name: "Playmobil The Secret of Pirate I"

According to sabre, the quotes in the arguments should not be where they are; they should be in the path. So the above should be
--image-path="ISO\[DVD] Playmobil Pirate Island [1D]" --image-name="Playmobil The Secret of Pirate I"

To Reproduce
Steps to reproduce the behavior:

Dump a disc.

Expected behavior
The quotes should be wrapped around the file and path names.

Originally created by @FoxhackDN on GitHub (Mar 7, 2025). Originally assigned to: @mnadareski on GitHub. **Version** - [x] Stable release 3.3.0 - [ ] WIP release (version here) **Build** What runtime version are you using? - [x] .NET 9.0 running on Windows 11 Pro **Describe the issue** Incorrectly placed quotes are appearing in the dumping log and command line when using Redumper to dump discs. An example in the command line can be seen here: ![Image](https://github.com/user-attachments/assets/275ee6d1-be20-47b4-b5bb-c8f22a1b6e5e) ``` redumper v2024.11.03 build_438 [Nov 3 2024, 00:08:55] arguments: dvd --verbose --debug --drive=D:\ --speed=72 --retries=100 "--image-path=ISO\[DVD] Playmobil Pirate Island [1D]" "--image-name=Playmobil The Secret of Pirate I" drive path: D:\ drive: HL-DT-ST - DVDRAM GE20LU10 (revision level: FE06, vendor specific: ..0010220822916E2055) drive configuration: GENERIC (read offset: +667, C2 shift: 0, pre-gap start: +0, read method: BE, sector order: DATA_C2_SUB) drive read speed: 34184 KB current profile: DVD-ROM image path: "ISO\[DVD] Playmobil Pirate Island [1D]" image name: "Playmobil The Secret of Pirate I" ``` According to sabre, the quotes in the arguments should not be where they are; they should be in the path. So the above should be ```--image-path="ISO\[DVD] Playmobil Pirate Island [1D]" --image-name="Playmobil The Secret of Pirate I"``` **To Reproduce** Steps to reproduce the behavior: Dump a disc. **Expected behavior** The quotes should be wrapped around the file and path names.

claunia added the bug label 2026-01-29 16:22:45 +00:00

claunia closed this issue

2026-01-29 16:22:45 +00:00

claunia commented

2026-01-29 16:22:46 +00:00

@mnadareski commented on GitHub (Apr 17, 2025):

This is a log output visual bug for Redumper. MPF is properly passing in the value as expected. If any space is found in the argument, it calls str_quoted_if_space. This is not an MPF issue.

@mnadareski commented on GitHub (Apr 17, 2025): This is a log output visual bug for Redumper. MPF is properly passing in the value as expected. If any space is found in the argument, it calls `str_quoted_if_space`. This is not an MPF issue.

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: SabreTools/MPF#817