SabreTools/MPF
1
0
Fork 0
mirror of https://github.com/SabreTools/MPF.git synced 2026-02-08 21:31:47 +00:00
Code Issues 392 Packages Projects Releases 20 Wiki Activity

Writing Artifacts w/Include Artifacts checkbox enabled is broken #829

New Issue
Closed
opened 2026-01-29 16:22:55 +00:00 by claunia · 4 comments
claunia commented 2026-01-29 16:22:55 +00:00
Owner
Copy Link

Originally created by @ArchivistGoals on GitHub (May 12, 2025).

Originally assigned to: @mnadareski on GitHub.

Before You Submit

  • Remember to try the latest WIP build to see if the issue has already been addressed.
  • Is it copy protection related? If so, report the issue here instead.
  • Check multiple discs to help narrow down the issue
  • Check the Options to see if changing any of those affects your issue.

If all of those fail, then continue...

Version
What version are you using?

  • Stable release (version here)
  • WIP release (3.3.0-22a125a838419b7855cb620a43ec5ed2ed1ffc3e)

Build
What runtime version are you using?

  • .NET 9.0 running on (Windows 11 Pro)

Describe the issue

The legacy feature to "Include Artifacts" checkbox should be removed. By default, this checkbox is left blank. However, end-users might feel inclined to check it, which can cause a writing .json file error to occur,

"Writing could not complete!"

This was evident while attempting to dump a LEGO Mindstorms Upgrade Disc CD-ROM. The above error message continued to be displayed during each dump attempt until the Include Artifacts checkbox was unticked.

To Reproduce
Steps to reproduce the behavior:

  1. Go to: Enabling Include Artifacts causes a .json writing error.
  2. Click on '....'

Image

  1. Scroll down to '....'
  2. See error (screenshot included)

Expected behavior
Redumper to finish. The logs to be written. And for the prompt to enter metadata without any error in the previous step.

Screenshots
If applicable, add screenshots to help explain your problem.

Additional context
n/a

Originally created by @ArchivistGoals on GitHub (May 12, 2025). Originally assigned to: @mnadareski on GitHub. **Before You Submit** - Remember to try the [latest WIP build](https://github.com/SabreTools/MPF/releases/tag/rolling) to see if the issue has already been addressed. - Is it copy protection related? If so, report the issue [here](https://github.com/SabreTools/BinaryObjectScanner/issues) instead. - Check multiple discs to help narrow down the issue - Check the Options to see if changing any of those affects your issue. If all of those fail, then continue... **Version** What version are you using? - [ ] Stable release (version here) - [x] WIP release (3.3.0-22a125a838419b7855cb620a43ec5ed2ed1ffc3e) **Build** What runtime version are you using? - [x] .NET 9.0 running on (Windows 11 Pro) **Describe the issue** The legacy feature to "Include Artifacts" checkbox should be removed. By default, this checkbox is left blank. However, end-users might feel inclined to check it, which can cause a writing .json file error to occur, "Writing could not complete!" This was evident while attempting to dump a LEGO Mindstorms Upgrade Disc CD-ROM. The above error message continued to be displayed during each dump attempt until the Include Artifacts checkbox was unticked. **To Reproduce** Steps to reproduce the behavior: 1. Go to: **Enabling Include Artifacts causes a .json writing error.** 2. Click on '....' ![Image](https://github.com/user-attachments/assets/981f725b-0be7-401d-859c-bf0d624dac82) 3. Scroll down to '....' 4. See error **(screenshot included)** **Expected behavior** Redumper to finish. The logs to be written. And for the prompt to enter metadata without any error in the previous step. **Screenshots** If applicable, add screenshots to help explain your problem. **Additional context** n/a
claunia added the bug label 2026-01-29 16:22:55 +00:00
claunia commented 2026-01-29 16:22:56 +00:00
Author
Owner
Copy Link

@mnadareski commented on GitHub (May 12, 2025):

This will likely not get removed as a part of this, but there is definitely a better way to handle the output data from a sufficiently large JSON with artifacts. It likely needs to either do an async write or a chunked write. Both are relatively easy to implement.

@mnadareski commented on GitHub (May 12, 2025): This will likely not get removed as a part of this, but there is definitely a better way to handle the output data from a sufficiently large JSON with artifacts. It likely needs to either do an async write or a chunked write. Both are relatively easy to implement.
claunia commented 2026-01-29 16:22:57 +00:00
Author
Owner
Copy Link

@mnadareski commented on GitHub (May 13, 2025):

Possibly addressed as of 4016b3fc19

@mnadareski commented on GitHub (May 13, 2025): Possibly addressed as of https://github.com/SabreTools/MPF/commit/4016b3fc19a61a545b9adef3bdf340f57842ae46
claunia commented 2026-01-29 16:22:57 +00:00
Author
Owner
Copy Link

@Deterous commented on GitHub (Oct 1, 2025):

@mnadareski I tested this on rolling, no errors for me when Include Artifacts checkbox is checked.

@Deterous commented on GitHub (Oct 1, 2025): @mnadareski I tested this on rolling, no errors for me when Include Artifacts checkbox is checked.
claunia commented 2026-01-29 16:22:58 +00:00
Author
Owner
Copy Link

@mnadareski commented on GitHub (Oct 8, 2025):

Unobserved in a long time, will close.

@mnadareski commented on GitHub (Oct 8, 2025): Unobserved in a long time, will close.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
duplicate
enhancement
good first issue
help wanted
invalid
pull-request
Mirrored from GitHub Pull Request
 question
regression
wontfix
No Label bug
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: SabreTools/MPF#829
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?