[Problem] Redumper C2 error count incorrect #835

New Issue

claunia · 2026-01-29T16:23:06Z

claunia commented

2026-01-29 16:23:06 +00:00

Originally created by @Deterous on GitHub (May 22, 2025).

Originally assigned to: @mnadareski on GitHub.

Redumper now prints correction statistics, after a refine it prints how many samples were corrected (not the final C2 error count). So, the C2 error correction needs to be subtracted.

if(dump_mode == DumpMode::DUMP)
    {
        ctx.dump_errors = errors;

        LOG("media errors: ");
        LOG("  SCSI: {}", errors.scsi);
        LOG("  C2: {}", errors.c2);
        LOG("  Q: {}", errors.q);
    }
    else if(dump_mode == DumpMode::REFINE)
    {
        LOG("correction statistics: ");
        LOG("  SCSI: {} samples", errors_initial.scsi - errors.scsi);
        LOG("  C2: {} samples", errors_initial.c2 - errors.c2);
        LOG("  Q: {} sectors", errors_initial.q - errors.q);
    }

A separate issue is that redumper logs that contain multiple runs will be incorrect. But this may be out of scope.

Originally created by @Deterous on GitHub (May 22, 2025). Originally assigned to: @mnadareski on GitHub. Redumper now prints correction statistics, after a refine it prints how many samples were corrected (not the final C2 error count). So, the C2 error correction needs to be subtracted. ``` if(dump_mode == DumpMode::DUMP) { ctx.dump_errors = errors; LOG("media errors: "); LOG(" SCSI: {}", errors.scsi); LOG(" C2: {}", errors.c2); LOG(" Q: {}", errors.q); } else if(dump_mode == DumpMode::REFINE) { LOG("correction statistics: "); LOG(" SCSI: {} samples", errors_initial.scsi - errors.scsi); LOG(" C2: {} samples", errors_initial.c2 - errors.c2); LOG(" Q: {} sectors", errors_initial.q - errors.q); } ``` A separate issue is that redumper logs that contain multiple runs will be incorrect. But this may be out of scope.

claunia added the bug label 2026-01-29 16:23:06 +00:00

claunia closed this issue

2026-01-29 16:23:06 +00:00

claunia commented

2026-01-29 16:23:07 +00:00

@mnadareski commented on GitHub (May 22, 2025):

The latter issue is likely the easiest to handle in this case. It would entail doing a full reset of the error count if the beginning of a new, full dump is found. A line matching DUMP: or what have you should be sufficient.

@mnadareski commented on GitHub (May 22, 2025): The latter issue is likely the easiest to handle in this case. It would entail doing a full reset of the error count if the beginning of a new, full dump is found. A line matching `DUMP:` or what have you should be sufficient.

claunia commented

2026-01-29 16:23:07 +00:00

@mnadareski commented on GitHub (May 22, 2025):

Resetting the Redump error count on finding a new INFO block has been implemented in 62ff0f955a

@mnadareski commented on GitHub (May 22, 2025): Resetting the Redump error count on finding a new `INFO` block has been implemented in https://github.com/SabreTools/MPF/commit/62ff0f955ac5d6986d7840e323a07c22100ef0c4

claunia referenced this issue

2026-01-29 16:25:54 +00:00

[PR #835] Update redumper to build 549 #1185

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: SabreTools/MPF#835