SabreTools/MPF
1
0
Fork 0
mirror of https://github.com/SabreTools/MPF.git synced 2026-02-07 21:30:16 +00:00
Code Issues 392 Packages Projects Releases 20 Wiki Activity

[Problem] MPF.Check always compressing logs even if don't use -z #867

New Issue
Closed
opened 2026-01-29 16:23:34 +00:00 by claunia · 5 comments
claunia commented 2026-01-29 16:23:34 +00:00
Owner
Copy Link

Originally created by @JohnVeness on GitHub (Oct 18, 2025).

Originally assigned to: @mnadareski on GitHub.

Version
What version are you using?

  • Stable release (version here)
  • WIP release 3.5.0-d6b28de5861cb482b1a8ff3e83216169c89d5b34

Build
What runtime version are you using?

  • .NET 9.0 running on Linux

Describe the issue
Current WIP MPF.Check is always compressing the log files, even if I don't include the -z option.

To Reproduce
Steps to reproduce the behavior:

  1. Dump a disc, e.g. an Xbox One disc, using e.g. redumper --image-path gamefolder --image-name game
  2. ls gamefolder
  3. Notice that game.log, game.physical, and game.state files are present
  4. MPF.Check xboxone -u redumper gamefolder/game.log
  5. ls gamefolder

Observed behavior
The game.log, game.physical, and game.state files are not present. Instead a game_logs.zip file is present.

Expected behavior
The game.log, game.physical, and game.state files are present. No .zip file is present.

Originally created by @JohnVeness on GitHub (Oct 18, 2025). Originally assigned to: @mnadareski on GitHub. **Version** What version are you using? - [ ] Stable release (version here) - [x] WIP release 3.5.0-d6b28de5861cb482b1a8ff3e83216169c89d5b34 **Build** What runtime version are you using? - [x] .NET 9.0 running on Linux **Describe the issue** Current WIP MPF.Check is always compressing the log files, even if I don't include the -z option. **To Reproduce** Steps to reproduce the behavior: 1. Dump a disc, e.g. an Xbox One disc, using e.g. `redumper --image-path gamefolder --image-name game` 2. `ls gamefolder` 3. Notice that `game.log`, `game.physical`, and `game.state` files are present 4. `MPF.Check xboxone -u redumper gamefolder/game.log` 5. `ls gamefolder` **Observed behavior** The `game.log`, `game.physical`, and `game.state` files are not present. Instead a `game_logs.zip` file is present. **Expected behavior** The `game.log`, `game.physical`, and `game.state` files are present. No .zip file is present.
claunia added the bug label 2026-01-29 16:23:34 +00:00
claunia commented 2026-01-29 16:23:35 +00:00
Author
Owner
Copy Link

@mnadareski commented on GitHub (Oct 18, 2025):

Flags as toggles when config exists will be in WIP when d2ed2f81ae is merged into main.

@mnadareski commented on GitHub (Oct 18, 2025): Flags as toggles when config exists will be in WIP when https://github.com/SabreTools/MPF/commit/d2ed2f81ae82a09e33f49b45cbb710ce4cb374da is merged into `main`.
claunia commented 2026-01-29 16:23:36 +00:00
Author
Owner
Copy Link

@JohnVeness commented on GitHub (Oct 18, 2025):

Ah sorry, I hadn't noticed that MPF.Check now reads config.json.

@JohnVeness commented on GitHub (Oct 18, 2025): Ah sorry, I hadn't noticed that MPF.Check now reads config.json.
claunia commented 2026-01-29 16:23:37 +00:00
Author
Owner
Copy Link

@mnadareski commented on GitHub (Oct 18, 2025):

Added a print that tells when the config is being used since I didn't realize that this would be an issue. That's in fae399f8bc

@mnadareski commented on GitHub (Oct 18, 2025): Added a print that tells when the config is being used since I didn't realize that this would be an issue. That's in https://github.com/SabreTools/MPF/commit/fae399f8bc1bdc4229f1c272a48388efcd31eb6d
claunia commented 2026-01-29 16:23:37 +00:00
Author
Owner
Copy Link

@JohnVeness commented on GitHub (Oct 18, 2025):

Yeah, it's mentioned in the release notes for 3.5.0 but maybe not as prominently as it could have been! To be honest I'm not even really sure why I have a config.json, as this is on a Linux PC so I've never run MPF.UI. Maybe it's from experiments I did some time ago with MPF.CLI, in which case who knows what the settings are. Anyway, now I know, I can delete the config.json no problem.

It might be nice if there was a command-line option to show the saved settings, like git config list or get_iplayer --prefs-show.

@JohnVeness commented on GitHub (Oct 18, 2025): Yeah, it's mentioned in the release notes for 3.5.0 but maybe not as prominently as it could have been! To be honest I'm not even really sure why I have a config.json, as this is on a Linux PC so I've never run MPF.UI. Maybe it's from experiments I did some time ago with MPF.CLI, in which case who knows what the settings are. Anyway, now I know, I can delete the config.json no problem. It might be nice if there was a command-line option to show the saved settings, like `git config list` or `get_iplayer --prefs-show`.
claunia commented 2026-01-29 16:23:37 +00:00
Author
Owner
Copy Link

@mnadareski commented on GitHub (Oct 19, 2025):

Fixed as of d2ed2f81ae and fae399f8bc

@mnadareski commented on GitHub (Oct 19, 2025): Fixed as of https://github.com/SabreTools/MPF/commit/d2ed2f81ae82a09e33f49b45cbb710ce4cb374da and https://github.com/SabreTools/MPF/commit/fae399f8bc1bdc4229f1c272a48388efcd31eb6d
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
duplicate
enhancement
good first issue
help wanted
invalid
pull-request
Mirrored from GitHub Pull Request
 question
regression
wontfix
No Label bug
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: SabreTools/MPF#867
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?