SabreTools/MPF
1
0
Fork 0
mirror of https://github.com/SabreTools/MPF.git synced 2026-02-03 21:29:27 +00:00
Code Issues 392 Packages Projects Releases 20 Wiki Activity

[Problem] Cleanup of InitializeUIValues #868

New Issue
Closed
opened 2026-01-29 16:23:34 +00:00 by claunia · 1 comment
claunia commented 2026-01-29 16:23:34 +00:00
Owner
Copy Link

Originally created by @Deterous on GitHub (Sep 26, 2025).

Originally assigned to: @mnadareski on GitHub.

Specifically, there are a few things that occur when no drive is connected:

SetSupportedDriveSpeed() shouldn't be run if there are no valid drives.

EnsureMediaInformation() runs when no valid drives are present, which (as of rolling build) causes the following useless message on startup:

Image

Somehow it's calling 3bf83378a2/MPF.Frontend/DumpEnvironment.cs (L350) with an unusual media type?

Originally created by @Deterous on GitHub (Sep 26, 2025). Originally assigned to: @mnadareski on GitHub. Specifically, there are a few things that occur when no drive is connected: SetSupportedDriveSpeed() shouldn't be run if there are no valid drives. EnsureMediaInformation() runs when no valid drives are present, which (as of rolling build) causes the following useless message on startup: <img width="409" height="60" alt="Image" src="https://github.com/user-attachments/assets/a2c1c284-97fc-48b0-95d4-fc283a1a15e1" /> Somehow it's calling https://github.com/SabreTools/MPF/blob/3bf83378a252a1567511a7f7528d61dbacad8e9a/MPF.Frontend/DumpEnvironment.cs#L350 with an unusual media type?
claunia added the bug label 2026-01-29 16:23:34 +00:00
claunia commented 2026-01-29 16:23:35 +00:00
Author
Owner
Copy Link

@Deterous commented on GitHub (Sep 29, 2025):

Fixed as of 69f855fc93

@Deterous commented on GitHub (Sep 29, 2025): Fixed as of 69f855fc9315e8dc5b1f599aba378867723df399
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
duplicate
enhancement
good first issue
help wanted
invalid
pull-request
Mirrored from GitHub Pull Request
 question
regression
wontfix
No Label bug
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
claunia
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: SabreTools/MPF#868
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?