mirror of
https://github.com/SabreTools/MPF.git
synced 2026-02-03 21:29:27 +00:00
[Request] Don't use absolute paths in the logs #892
Reference in New Issue
Block a user
Delete Branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @mariomadproductions on GitHub (Jan 27, 2026).
Originally assigned to: @mnadareski on GitHub.
See also:
DIC issue https://github.com/saramibreak/DiscImageCreator/issues/191
redumper issue https://github.com/superg/redumper/issues/339
i.e. in submissioninfo
Parameters: disc --skeleton --drive=D:\ --speed=16 --retries=20 "--image-path=C:\Users\user1\Documents\my\appdocs\mpf\iso\DISNEY BOLT" "--image-name=DISNEY BOLT"C:\Users\user1\Documents\my\appdocs\mpf\iso\DISNEY BOLTshould be[truncated]\DISNEY BOLTThis is due to privacy issues some people have, which can cause issues with log sharing.
@mnadareski commented on GitHub (Jan 27, 2026):
If privacy-focused flags are added to the dumping programs, then I will add them as supported to MPF. I am unlikely to do any manual redaction otherwise.
@Deterous commented on GitHub (Jan 27, 2026):
This is already a thing. MPF will give relative paths by default and redumper will only print relative paths.
@mariomadproductions commented on GitHub (Jan 27, 2026):
That's true, but if you choose a custom absolute path (as you sometimes may need/want to do), MPF uses an absolute path in the command line. An alternative to that could be setting the "run in" directory for the command to the absolute path, then using the current dir in the command line.
@Deterous commented on GitHub (Jan 29, 2026):
That feels like a trap, there may be some unforeseen issues with running a SCSI-device-using CLI program in some directories.
@mariomadproductions commented on GitHub (Jan 29, 2026):
I'm not sure by what mechanism that would happen, unless some programs are designed to only work in the same directory as their exe, which I guess could be true.
But maybe MPF should just give an absolute path, and pass a param like --censor-full-path to redumper, which redumper will follow.
@mnadareski commented on GitHub (Jan 29, 2026):
Given that this is in the hands of the dumping programs and not MPF, I am closing the issue here as any new flags will be supported whenever the programs themselves get an update.