[PR #4] [MERGED] Fix a few issues #896

New Issue

Open

opened 2026-01-29 16:24:10 +00:00 by claunia · 0 comments

claunia commented 2026-01-29 16:24:10 +00:00

Owner

Copy Link

📋 Pull Request Information

Original PR: https://github.com/SabreTools/MPF/pull/4
Author: @NHellFire
Created: 5/14/2018
Status: ✅ Merged
Merged: 5/14/2018
Merged by: @undefined

Base: master ← Head: patch-1

---

📝 Commits (3)

• d21a5c8 Fix PC CD (no copy protection) arguments
• da4d9fb Quote output path as it may contain spaces
• eb664ce Make sure output directory has a trailing backslash for PSX commands

📊 Changes

1 file changed (+10 additions, -10 deletions)

View changed files

📝 MainWindow.xaml.cs (+10 -10)

📄 Description

Fixed a few issues I found:

1. PC CD (no copy protection) had type set to dvd
2. Output path wasn't quoted when running DiscImageCreator
3. PSX.bat was missing backslashes after output directory

---

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/SabreTools/MPF/pull/4 **Author:** [@NHellFire](https://github.com/NHellFire) **Created:** 5/14/2018 **Status:** ✅ Merged **Merged:** 5/14/2018 **Merged by:** [@undefined](undefined) **Base:** `master` ← **Head:** `patch-1` --- ### 📝 Commits (3) - [`d21a5c8`](https://github.com/SabreTools/MPF/commit/d21a5c84955e05a81a75dafb317bedd34b3f1ff0) Fix PC CD (no copy protection) arguments - [`da4d9fb`](https://github.com/SabreTools/MPF/commit/da4d9fbf6745ef6b5c2cd1f70f83ec024127c2aa) Quote output path as it may contain spaces - [`eb664ce`](https://github.com/SabreTools/MPF/commit/eb664cebba57d210447a97165abf9a1e0f0cbd16) Make sure output directory has a trailing backslash for PSX commands ### 📊 Changes **1 file changed** (+10 additions, -10 deletions) <details> <summary>View changed files</summary> 📝 `MainWindow.xaml.cs` (+10 -10) </details> ### 📄 Description Fixed a few issues I found: 1. PC CD (no copy protection) had type set to dvd 2. Output path wasn't quoted when running DiscImageCreator 3. PSX.bat was missing backslashes after output directory --- _{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

claunia added the pull-request label 2026-01-29 16:24:10 +00:00

claunia referenced this issue 2026-01-29 16:26:08 +00:00

[PR #896] [MERGED] Support reparsing of MPF-processed outputs #1221

Sign in to join this conversation.

No Branch/Tag Specified

Branches Tags

master

rolling

3.6.0

3.5.0

3.4.2

3.4.1

3.4.0

3.3.3

3.3.2

3.3.1

3.3.0

3.2.4

3.2.3

3.2.2

3.2.1

3.2.0

3.1.9

3.1.8

3.1.7

3.1.6

3.1.5

3.1.4

3.1.3

3.1.2

check-rolling

ui-rolling

3.1.1

3.1.0

3.0.3

3.0.2

3.0.1

3.0.0

2.7.5

2.7.4

2.7.3

2.7.2

2.7.1

2.7.0

2.6.6

2.6.5

2.6.4

2.6.3

2.6.2

2.6.1

2.6

2.5

2.4

2.3

2.2

2.1

2.0

1.18

1.17.1

1.17

1.16.1

1.16

1.15

1.14

1.13

1.12.2

1.12.1

1.12

1.11

1.10

1.07

1.06

1.05.1

1.05

1.04b

1.04a

1.04

1.03

1.02b

1.02

1.01d

1.01c

1.01b

Labels

Clear labels

bug

duplicate

enhancement

good first issue

help wanted

invalid

pull-request

Mirrored from GitHub Pull Request

question

regression

wontfix

No Label pull-request

Milestone

No items

No Milestone

Projects

Clear projects

No project

Assignees

Clear assignees

claunia

No Assignees

1 Participants

Notifications

Subscribe

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: SabreTools/MPF#896